Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 3.2.0-RC: PDF-Export download-window does not open #2463

Closed
modelrailroader opened this issue May 27, 2023 · 4 comments
Closed

Bug: 3.2.0-RC: PDF-Export download-window does not open #2463

modelrailroader opened this issue May 27, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@modelrailroader
Copy link
Contributor

When trying to export a pdf and clicking on "download" instead of "inline", the download window does not open and the pdf is shown inline instead.

Browser: Mozilla Firefox 113.0.2
phpMyFAQ-Version: 3.2.0-RC

Feel free to ask me, if you have questions.

@thorsten thorsten self-assigned this May 27, 2023
@thorsten thorsten added the Bug label May 27, 2023
@thorsten thorsten added this to the 3.2 milestone May 27, 2023
@modelrailroader
Copy link
Contributor Author

I just saw that the same "problem" is existing in 3.1 as well, but I never noticed it as a real problem because the download is just one click away.
I tried to solve it but as I see it right now, there's no easy solution. I'd close this issue if you share my opinion.

After this, I'm done with all my Pull Requests I wanted to add. So, you do not longer have to wait for me with releasing the final 3.2. Thank's again!

@modelrailroader
Copy link
Contributor Author

Closed #2463

@modelrailroader modelrailroader closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2023
@thorsten
Copy link
Owner

The initial implementation was back in the time when browser had no PDF viewer included. Maybe the inline option makes no sense at all.

@modelrailroader
Copy link
Contributor Author

Yeah, you could be right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants