Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0: No # in faq name #2632

Closed
modelrailroader opened this issue Sep 10, 2023 · 2 comments · Fixed by #2651
Closed

4.0: No # in faq name #2632

modelrailroader opened this issue Sep 10, 2023 · 2 comments · Fixed by #2651
Assignees
@thorsten @modelrailroader
Labels
New feature
Milestone
4.0

Comments

@modelrailroader
Copy link
Contributor

The symbol '#' should not be allowed in record titles as they are not working with htaccess-routes.
@thorsten
Copy link
Owner

I think that's an issue in 3.2 as well?

@modelrailroader
Copy link
Contributor Author

Probably but in 3.3 it's important to know because due to routing and the htaccess changes # are not allowed in urls and records with # in the title aren't found

@thorsten thorsten self-assigned this Sep 10, 2023
@thorsten thorsten added this to the 3.3 milestone Sep 10, 2023
thorsten added a commit that referenced this issue Sep 11, 2023
@thorsten
feat: added method to check for # (#2632)
4da21af
@modelrailroader modelrailroader mentioned this issue Sep 20, 2023
Merged
@thorsten thorsten changed the title 3.3: No # in faq name 4.0: No # in faq name Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thorsten thorsten

@modelrailroader modelrailroader

Labels
New feature
Projects
No open projects
phpMyFAQ 4.0.0-alpha
Status: Done
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

No # in faq name
2 participants
@thorsten @modelrailroader