Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lottie/slot: multiple properties in single slot not working #2045

Closed
tinyjin opened this issue Mar 11, 2024 · 0 comments
Closed

Lottie/slot: multiple properties in single slot not working #2045

tinyjin opened this issue Mar 11, 2024 · 0 comments
Assignees
Labels
enhancement Improve features lottie Lottie animation

Comments

@tinyjin
Copy link
Member

tinyjin commented Mar 11, 2024

if the slotJson has more than two properties, only first sid is overridden .
We might need to support overriding all from each slot.

{
  "ball_color": {
    "p": {
      "a": 0,
      "k": [
        0.1,
        1,
        0.5,
        1
      ]
    }
  },
  "background_color": { // ignored
    "p": {
      "a": 0,
      "k": [
        1,
        1,
        1,
        1
      ]
    }
  }
}

Should add looping condition it works until all sid is consumed in bool LottieLoader::override(const char* slot) in tvgLottieLoader.cpp

@tinyjin tinyjin added enhancement Improve features lottie Lottie animation labels Mar 11, 2024
@tinyjin tinyjin self-assigned this Mar 11, 2024
@hermet hermet closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve features lottie Lottie animation
Projects
None yet
Development

No branches or pull requests

2 participants