Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvOS target #9

Merged
merged 2 commits into from Sep 26, 2015
Merged

Add tvOS target #9

merged 2 commits into from Sep 26, 2015

Conversation

nickygerritsen
Copy link
Contributor

I'm not sure whether you already want to add this before the watchOS SDK gets a GM or stable release, but nevertheless you can then probably use it later without changing much. I needed it anyway to test an SDK I am creating on tvOS so I might as well create a PR for it :).

@gfontenot
Copy link
Collaborator

This is fantastic, thanks for putting this together.

In order to keep Carthage installs from breaking, we can't ship a shared scheme. Do you mind _un_sharing the scheme for now, and I will make a branch that you can point at that will have a shared scheme?

@nickygerritsen
Copy link
Contributor Author

No problem, will do this tomorrow :)

@nickygerritsen
Copy link
Contributor Author

OK it is unshared now. The scheme is now not committed, because it is in my xcuserdata directory. Is that correct or should I commit the file anyway?

@gfontenot
Copy link
Collaborator

Nope, that's exactly right. I'll check that box in a tvos branch and that'll commit it into the repo.

@nickygerritsen
Copy link
Contributor Author

But you can't access that box now right? Because the scheme is not there... Or do I miss something here

@gfontenot
Copy link
Collaborator

It is. Xcode auto-creates the scheme for the current user when you open the project.

@nickygerritsen
Copy link
Contributor Author

Ahhhh ok. Magic!

@nickygerritsen
Copy link
Contributor Author

@gfontenot Are you waiting on me for something to merge this one or am I missing something?

@gfontenot
Copy link
Collaborator

Nope, sorry, just haven't had time. Will get to this ASAP.

@gfontenot gfontenot merged commit 6c89d47 into thoughtbot:master Sep 26, 2015
@gfontenot
Copy link
Collaborator

bam

asap'd

Thanks!

@gfontenot
Copy link
Collaborator

And I've created a tvos branch if anyone wants to point at that directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants