New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Swift 4.2 #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is a good start! I'd love to add this in a backwards-compatible way if possible — left a couple of ideas in the comments, let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a couple more suggestions
1eda55c
to
bd3edc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks like CI is still failing, mind taking a look? |
Upgrades the pod from using Swift 4 to Swift 4.2, avoiding having to do compatibility checks in the
Podfile
of a project built in Xcode 10.1 (specifying the version of Swift needed to build the target, such as CocoaPods/CocoaPods#6791).