Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 4.2 #25

Merged
merged 4 commits into from Mar 7, 2019
Merged

Update to Swift 4.2 #25

merged 4 commits into from Mar 7, 2019

Conversation

patrickmontalto
Copy link
Contributor

Upgrades the pod from using Swift 4 to Swift 4.2, avoiding having to do compatibility checks in the Podfile of a project built in Xcode 10.1 (specifying the version of Swift needed to build the target, such as CocoaPods/CocoaPods#6791).

Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is a good start! I'd love to add this in a backwards-compatible way if possible — left a couple of ideas in the comments, let me know what you think.

Tests/Harness/AppDelegate.swift Outdated Show resolved Hide resolved
Tests/Harness/AppDelegate.swift Outdated Show resolved Hide resolved
Sources/Perform/UIViewController.swift Show resolved Hide resolved
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple more suggestions

Sources/Perform/UIViewController.swift Outdated Show resolved Hide resolved
Tests/Harness/AppDelegate.swift Outdated Show resolved Hide resolved
Tests/Harness/AppDelegate.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Tests/Harness/AppDelegate.swift Outdated Show resolved Hide resolved
@sharplet
Copy link
Contributor

sharplet commented Mar 7, 2019

Looks like CI is still failing, mind taking a look?

@patrickmontalto patrickmontalto merged commit e0009ff into master Mar 7, 2019
@patrickmontalto patrickmontalto deleted the pm-swift-4.2 branch March 7, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants