Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to circle ci 2.0 #26

Merged
merged 1 commit into from Mar 7, 2019
Merged

Update to circle ci 2.0 #26

merged 1 commit into from Mar 7, 2019

Conversation

patrickmontalto
Copy link
Contributor

Why

  • Old Xcode version used on Circle was causing tests to fail.
  • Circleci 1.0 is going away on March 15 (~a week from today)

How

  • Specify Xcode 10.1.0 and use circle 2.0

sharplet
sharplet reviewed Mar 7, 2019
View reviewed changes
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! If you haven't already, don't forget to define CARTHAGE_CACHE_VERSION in the Circle CI project settings. And maybe rerun to validate that the caching is working as expected?

@patrickmontalto patrickmontalto merged commit 8ba6003 into pm-swift-4.2 Mar 7, 2019
@patrickmontalto patrickmontalto deleted the pm-circle2.0 branch March 7, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharplet sharplet sharplet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrickmontalto @sharplet