Add UITabBarController.configureViewControllers #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies passing dependencies to tabs within a tab bar controller by searching within each tab's view controller hierarchy for a matching view controller to configure.
This name more clearly suggests that we are configuring the tab bar controller's `viewControllers` array.
sharplet
changed the title
UITabBarController.configureTabs
|
👍 |
| import UIKit | ||
|
|
||
| extension UIViewController { | ||
| public func childViewController<Child: UIViewController>(ofType type: Child.Type) -> Child? { |
There was a problem hiding this comment.
Since this is public, it might be nice to add a doc comment as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6.
Simplifies passing dependencies to tabs within a tab bar controller by searching within each tab's view controller hierarchy for a matching view controller to configure.