Add support to Mailgun adapter for using custom vars #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a must for webhook callbacks. Thank you @jfcalvo |
|
@paulcsmith there is some problem with the PRs? This one has like 4 months of time. Can anybody merge it? Thanks in advance. |
|
@jfcalvo Thanks for pinging. This looks great! |
|
@paulcsmith It looks like #307 (Mailgun attachment support) was waiting on this merge. Is it now possible to get #307 resolved and merged? We'd really like to start sending attachments with Mailgun and Bamboo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for Mailgun custom variables as defined on Mailgun documentation.
Tested and working with Mailgun.
Related issue #305