Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and documentation #454

Merged
merged 5 commits into from Feb 26, 2019

Conversation

@maymillerricci
Copy link
Member

commented Feb 26, 2019

Minor fixes including typos and updates to code examples in the README that came up as I was trying to follow along setting up Bamboo.

Includes a typo fix for #449.

@@ -241,13 +241,13 @@ You can use the Bamboo.TestAdapter along with [Bamboo.Test] to make testing your
emails straightforward.

```elixir
# Using the mailer from the Getting Started section

This comment has been minimized.

Copy link
@maymillerricci

maymillerricci Feb 26, 2019

Author Member

This example really assumes more than the mailer from the Getting Started section, so I think it's better just not to say anything about it.

@germsvel
Copy link
Contributor

left a comment

💯 thanks for fixing all of these!

@jutonz
jutonz approved these changes Feb 26, 2019
Copy link

left a comment

🍰

@maymillerricci maymillerricci merged commit e3257ce into master Feb 26, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@maymillerricci maymillerricci deleted the mmr-cleanup branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.