Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example for MandrillHelper.put_param/3 #593

Merged
merged 1 commit into from Mar 26, 2021

Conversation

shawnleong
Copy link
Contributor

Thanks for open-sourcing and the work behind bamboo.
I was perusing the docs and got slightly confused by the example before realising it was an error in the given example.

Background

The example for Bamboo.MandrillHelper.put_param/3 is incorrectly calling on a non-existent put_param/4

  • The example passes email twice to the function
  • First through the pipeline
  • Second through the function argument

Fix

This merge request aims to corrects the example in the documentation.

Copy link
Collaborator

@germsvel germsvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this fix! Always very much appreciated.

@germsvel germsvel merged commit 7e84187 into beam-community:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants