Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower.json "main" should contain everything in dist/ #400

Closed
kflorence opened this issue Apr 16, 2014 · 6 comments
Closed

bower.json "main" should contain everything in dist/ #400

kflorence opened this issue Apr 16, 2014 · 6 comments

Comments

@kflorence
Copy link

Right now it only has _bourbon.scss which is pretty useless since everything that file imports is not included.

@plapier
Copy link

plapier commented Apr 19, 2014

Can you submit a PR or recommend what the bower.json file should look like?

@kflorence
Copy link
Author

@plapier Sure, it should look very similar to this: https://github.com/twbs/bootstrap-sass/blob/master/bower.json

I'd be happy to submit a pull request for it, I just wasn't sure if the bower.json file was generated automatically or not.

@plapier
Copy link

plapier commented Apr 23, 2014

The bower.json file in bootstrap only contains one .scss file. The rest are font and js files. I would have expected it to include everything in: https://github.com/twbs/bootstrap-sass/tree/master/vendor/assets/stylesheets/bootstrap

@plapier
Copy link

plapier commented Apr 23, 2014

@kflorence I just ran the following command and everything seems to get downloaded properly for bower

bower install bourbon#3.2.1

As you can see, the entire /dist/ directory is there.

screen shot 2014-04-23 at 11 05 55 am

@kflorence
Copy link
Author

@plapier Heh, poor timing on my part it seems: twbs/bootstrap-sass@83584d7

To clarify, the bower.json file as it is now works fine for installing directly via bower install -- however, it isn't compatible with a lot of bower installation tools (which is what the "main" property is primarily used by).

It looks like there is some internal debate going on around the proper standard usage of the "main" property which you can read about here twbs/bootstrap-sass#586 (comment) and here bower/bower#935

In short, what is in the bower.json file now will work nicely for some tools, but break others. I think this issue should remain open until a solid answer from the Bower team is given, although no change on your part is necessary now.

Sorry for the confusion.

@tysongach
Copy link
Contributor

Closing this, as it seems to be working for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants