Allow setting associations to nil #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcsmith
approved these changes
Jan 27, 2017
| Enum.map(original_assoc, &(cast(&1))) | ||
|
|
||
| nil -> | ||
| nil |
Previously the catchall was falling through to the list case and trying to enumerate `nil`. This commit adds a guard to the list condition to ensure that doesn't happen again, then adds a new condition to handle `nil`. I _think_ this should be handling all cases now, so it also removes the catchall. This way, if it fails in a way we didn't expect, it should give an obvious failure that there was no matching case. Fixes #191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the catchall was falling through to the list case and trying
to enumerate
nil. This commit adds a guard to the list condition toensure that doesn't happen again, then adds a new condition to handle
nil.I think this should be handling all cases now, so it also removes the
catchall. This way, if it fails in a way we didn't expect, it should
give an obvious failure that there was no matching case.
Fixes #191