factory_girl_rails/factory_bot_rails RuntimeError: can't modify frozen Array #247

torntrousers · 2017-10-26T13:05:38Z

I've followed the instructions in the blog post about how to make the factory_girl_rails/factory_bot_rails rename and now tests fail with 'can't modify frozen Array', eg:

RuntimeError:
  can't modify frozen Array
# ./config/environment.rb:5:in `<top (required)>'
# ./spec/rails_helper.rb:2:in `<top (required)>'
# ./spec/models/user_state_machine_spec.rb:1:in `<top (required)>'

I'm totally new to rails and Ruby so likely a user error, but what? Any pointers on what I'm doing wrong?

Thanks!

The text was updated successfully, but these errors were encountered:

joshuaclayton · 2017-10-26T13:20:24Z

@torntrousers to confirm, pre-rename, you were not seeing this error, correct?

Out of curiosity, is it possible you could provide the git diff from your change? If you're on a Mac, you should be able to run git show HEAD | pbcopy and paste in here, or send to me directly, if you've commited the changes.

Another possible culprit: you had a file with the name factory_girl in it somewhere in your repo, and when you ran the recommend grep/sed commands, it updated require "my/factory_girl/file" to require "my/factory_bot/file" without you moving the file.

Without being able to see what changed, it's difficult to nail down what the issue is, but those are the two places I'd start.

torntrousers · 2017-10-26T13:26:03Z

Yes the tests work fine if I change it all back to factory-girl. Here is the git diff:

git status
On branch factory-bot-name-change
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   Gemfile
	modified:   Gemfile.lock
	modified:   config/application.rb
	modified:   spec/rails_helper.rb

no changes added to commit (use "git add" and/or "git commit -a")

and

git diff Gemfile
diff --git a/Gemfile b/Gemfile
index c50e9769..b89987dd 100644
--- a/Gemfile
+++ b/Gemfile
@@ -61,7 +61,7 @@ group :test do
   gem "capybara"
   gem "capybara-webkit"
   gem "database_cleaner"
-  gem "factory_girl_rails"
+  gem "factory_bot_rails"
   gem "faker"
   gem "fakeredis", require: "fakeredis/rspec"
   gem "multi_xml"
~/Development/phone-platform> git diff Gemfile.lock
diff --git a/Gemfile.lock b/Gemfile.lock
Rename factory-girl-rails to factory-bot-rails
index 35e081bd..20520657 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -200,10 +200,10 @@ GEM
       activemodel
     erubis (2.7.0)
     execjs (2.7.0)
-    factory_girl (4.8.0)
+    factory_bot (4.8.2)
       activesupport (>= 3.0.0)
-    factory_girl_rails (4.8.0)
-      factory_girl (~> 4.8.0)
+    factory_bot_rails (4.8.2)
+      factory_bot (~> 4.8.2)
       railties (>= 3.0.0)
     faker (1.8.4)
       i18n (~> 0.5)
@@ -517,7 +517,7 @@ DEPENDENCIES
   dotenv-rails (~> 2.1.0)
   dynamic_form
   email_validator
-  factory_girl_rails
+  factory_bot_rails
   faker
   fakeredis
   flag_shih_tzu

config/application.rb
@@ -61,7 +61,7 @@ class Application < Rails::Application
     config.generators do |g|
        g.test_framework      :rspec, :fixture => true
 -      g.fixture_replacement :factory_girl, :dir => "spec/factories"
 +      g.fixture_replacement :factory_bot, :dir => "spec/factories"
        g.template_engine     :haml
      end

spec/rails_helper.rb
@@ -44,7 +44,7 @@ def mock_mydrive_api
   config.include ControllerHelpers, type: :controller
    config.include Rack::Test::Methods, type: :rack
 -  config.include FactoryGirl::Syntax::Methods
 +  config.include FactoryBot::Syntax::Methods
  
    config.include RSpec::Rails::RequestExampleGroup, capybara_feature: true, type: :feature

joshuaclayton · 2017-10-26T14:08:20Z

@torntrousers ah, excellent; can you check to see what changed in config/application.rb? Since that showed up in the original backtrace, I wonder if it got changed unexpectedly.

torntrousers · 2017-10-26T15:33:07Z

diff --git a/config/application.rb b/config/application.rb
index 4a37cabd..a40b74f6 100644
--- a/config/application.rb
+++ b/config/application.rb
@@ -61,7 +61,7 @@ module PhonePlatform

     config.generators do |g|
       g.test_framework      :rspec, :fixture => true
-      g.fixture_replacement :factory_girl, :dir => "spec/factories"
+      g.fixture_replacement :factory_bot, :dir => "spec/factories"
       g.template_engine     :haml
     end

joshuaclayton · 2017-10-26T21:18:09Z

@torntrousers ah, apologies - I missed this when you posted the diff.

There's nothing that's immediately obvious to me as actively causing this. Can you provide what command (or commands, if you're able to reproduce in other ways) that trigger this exception? (e.g. were you running rake, rspec spec, bundle exec rake, rails generate model foo bar baz)

The fact it travels all the way back to the application, which runs Bundler.require(*Rails.groups), makes me wonder if it's something with spring, maybe, since that's very much in the application load order and is operating on an array that could consider itself modified (since the list of gems has technically changed). Could you run spring stop and try whatever command(s) again?

torntrousers · 2017-10-26T22:05:31Z

After doing bundle install to get the error i do "bin/rake parallel:spec".
I've tried spring stop but it says spring is not running. So I tried restarting the mac but after that it still gets lots of "can't modify frozen Array" error. Then switching from my git branch with just this change back to master and doing bundle install and "bin/rake parallel:spec" and the tests all work fine again.
(and thanks for your help with this!)

torntrousers · 2017-10-27T09:24:24Z

Sorted!
The problem was that the grep command given in the blog post to Replace All Constant References didn't actually change all the instances of FactoryGirl in the code base. After we found that and did a global change with Atom it all works fine.
This is an example diff of one of the files missed by the grep that I had to manually change:

git diff spec/factories/activation_code.rb
diff --git a/spec/factories/activation_code.rb b/spec/factories/activation_code.rb
index 493f7942..8c727cb5 100644
--- a/spec/factories/activation_code.rb
+++ b/spec/factories/activation_code.rb
@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :activation_code do
     code { Faker::Lorem.characters(6) }
     code_valid { true }

Something like this grep looks like it fixes it:
grep -rl 'FactoryGirl' ./ | xargs sed -i '' 's/FactoryGirl/FactoryBot/g'

joshuaclayton · 2017-10-27T09:28:08Z

@torntrousers ah, excellent! I hadn't thought to ask about if other constants existed; I'd actually just attempted to recreate by adding parallel_tests to a repo 😃 to see if that was involved.

I'm glad to hear it! We ended up updating the command suggested in the upgrade doc since some people won't have rakefiles that include it (so, we added the -s flag for silencing unmatched files instead of failing).

I'm glad to hear it worked out, and thanks for your patience while we debugged; without access to the codebase, these problems are always a bit trickier!

JalisoCSP · 2018-08-28T13:22:58Z

This same issue seems to have happened to us on the update from 4.10.0 to 4.11.0, although the releases show "No notable changes"

We literally changed the version number and bundled.

joshuaclayton · 2018-08-28T13:25:36Z

@JalisoCSP did any other gems get bumped in the upgrade? Can you provide a backtrace, and perhaps the line(s) that seem to be causing the problem?

JalisoCSP · 2018-08-28T13:34:50Z

@joshuaclayton - Fast response! There was a few, but we've since narrowed it down to this gem being bumped - eg; we took this upgrade out and everything was fine.

Failure/Error: require File.expand_path("../../config/environment", __FILE__)

FrozenError:
  can't modify frozen Array

# ./config/environment.rb:17:in `<top (required)>'
# ./spec/spec_helper.rb:14:in `<top (required)>'
# ./spec/<our_spec_file>_spec.rb:1:in `<top (required)>'

respectively:
-> Rails.application.initialize!
-> require File.expand_path("../../config/environment", __FILE__)
-> require 'spec_helper'

(Edit: tag)

joshuaclayton · 2018-08-28T15:47:51Z

@JalisoCSP is there further backtrace you can provide? There's nothing obvious/unique here that would point to FB - or really anything else - directly, so it's hard to provide any suggestions right now.

JalisoCSP · 2018-08-29T09:58:04Z

@joshuaclayton nothing too useful, I'm afraid.

Here it is, in case it helps:

An error occurred while loading .<spec_path>_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)

FrozenError:
  can't modify frozen Array
# [gem path]/actionpack-5.2.1/lib/action_dispatch/middleware/stack.rb:76:in `insert'
# [gem path]/actionpack-5.2.1/lib/action_dispatch/middleware/stack.rb:76:in `insert'
# [gem path]/sentry-raven-2.7.4/lib/raven/integrations/rails.rb:10:in `block in <class:Rails>'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:32:in `instance_exec'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:32:in `run'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:61:in `block in run_initializers'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:60:in `run_initializers'
# [gem path]/railties-5.2.1/lib/rails/application.rb:361:in `initialize!'
# ./config/environment.rb:17:in `<top (required)>'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `block in require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# ./spec/spec_helper.rb:14:in `<top (required)>'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `block in require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# .<spec_path>_spec.rb:1:in `<top (required)>'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:82:in `load'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:82:in `load'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:74:in `load'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `block in load'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `load'

This is on Rails 5.2.1 and Ruby 2.5.1

(Edits: Bad copy and paste when removing long [gem path] 👍)

KelseyDH · 2018-09-05T00:08:36Z

Having the same problem after changing to FactoryBot from FactoryGirl and factory_girl_rails to factory_bot_rails

NOTE: if you get this test error, the very first test error will give you more details on what's breaking.

kirylrb · 2018-09-12T09:08:42Z

In my case issue was caused by rails_admin recent upgrade:

RuntimeError:
  Required middlewares for RailsAdmin are not added
  To fix tihs, add

    config.middleware.use ActionDispatch::Flash

  to config/application.rb.

Mohakjuneja · 2018-10-10T20:41:32Z

@joshuaclayton nothing too useful, I'm afraid.

Here it is, in case it helps:

An error occurred while loading .<spec_path>_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)

FrozenError:
  can't modify frozen Array
# [gem path]/actionpack-5.2.1/lib/action_dispatch/middleware/stack.rb:76:in `insert'
# [gem path]/actionpack-5.2.1/lib/action_dispatch/middleware/stack.rb:76:in `insert'
# [gem path]/sentry-raven-2.7.4/lib/raven/integrations/rails.rb:10:in `block in <class:Rails>'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:32:in `instance_exec'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:32:in `run'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:61:in `block in run_initializers'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:60:in `run_initializers'
# [gem path]/railties-5.2.1/lib/rails/application.rb:361:in `initialize!'
# ./config/environment.rb:17:in `<top (required)>'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `block in require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# ./spec/spec_helper.rb:14:in `<top (required)>'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `block in require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# .<spec_path>_spec.rb:1:in `<top (required)>'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:82:in `load'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:82:in `load'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:74:in `load'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `block in load'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `load'

This is on Rails 5.2.1 and Ruby 2.5.1

(Edits: Bad copy and paste when removing long [gem path] 👍)

How did you resolve this? I've been struggling with the same error

JalisoCSP · 2018-10-11T15:12:38Z

How did you resolve this? I've been struggling with the same error

We never did. We're still on 4.10.0

CC: @Mohakjuneja

composerinteralia · 2018-10-18T11:57:54Z

The stack trace given on rails/rails#33745 looks fairly similar to this, and it seems to have been related to a rails_admin initializer running after the build_middleware_stack initializer.

The build_middleware_stack initializer freezes the middleware array:

From the stack trace in this issue, it looks like when sentry-raven inserts its middleware it is happening after the middleware array has been frozen.

I don't see how factory_bot_rails could have much effect here, since we don't do anything with middleware at all, but we did just got a new issue about this: #303.

lstone · 2018-11-06T01:59:58Z

This happened to me when I declared two factories w/ the same name.

composerinteralia · 2018-11-06T02:07:30Z

See #303 (comment) for more details

nezirz · 2019-03-13T21:43:54Z

I had the same problem when tried to upgrade fromrails 5.2.0 to 5.2.2.1using bundle update rails command, its also updated many other gems one of them was factory_bot from 4.10.0 to 5.0.2 so solution was to downgrade to 4.10.0 by specifying the version number for factory_bot to gem "factory_bot_rails", "~> 4.10.0"

composerinteralia · 2019-03-13T21:58:07Z

@nezirz there were some deprecations in factory_bot 4.11, so you will want to upgrade to that version and deal with the warnings before upgrading to factory_bot 5.0.

AlessandroMinali · 2019-04-01T17:55:26Z

Great tip @composerinteralia.

basically to solve this issue:

rubocop \
  --require rubocop-rspec \
  --only FactoryBot/AttributeDefinedStatically \
  --auto-correct

The errors with 5.0 occur because of the deprecation of static var in factories. Gl all.

pavkosykh · 2019-04-24T08:50:09Z

Great tip @composerinteralia.

basically to solve this issue:
rubocop \
  --require rubocop-rspec \
  --only FactoryBot/AttributeDefinedStatically \
  --auto-correct
The errors with 5.0 occur because of the deprecation of static var in factories. Gl all.

Thanks a lot, this helped to solve problem!

schmijos · 2019-04-29T08:49:49Z

The update 5.0.1 → 5.0.2 makes this occur again?

composerinteralia · 2019-04-29T11:39:38Z

@schmijos there are no intentional breaking changes from factory_bot_rails 5.0.1 to 5.0.2. The FrozenError is not coming from factory_bot (see #303 for details). If you want to see the underlying factory_bot error try running just one of the failing specs at a time.

deepak-sweeten · 2019-04-30T07:34:17Z

I was getting the same error. I fixed by removing require 'rails_helper' from spec files. It was causing the issue for me. I am not sure but it seems somewhere it was trying to load these helpers multiple time and it was causing can't modify frozen Array.

marcelobarreto · 2019-05-25T01:17:35Z

In my case, just changed my factory field from password 123456 to password { 123456 } solved.

mike927 · 2019-10-02T16:46:10Z

gem install rubocop-rspec
and then
rubocop --require rubocop-rspec --only FactoryBot/AttributeDefinedStatically --auto-correct

worked for me

joshuaclayton closed this as completed Oct 26, 2017

joshuaclayton reopened this Oct 26, 2017

joshuaclayton closed this as completed Oct 27, 2017

composerinteralia mentioned this issue Oct 15, 2018

FrozenError when adding a factory called :product #303

Closed

gauravtiwari mentioned this issue Dec 20, 2018

Rails 5 app can't boot if webpack-dev-server config is present rails/webpacker#1847

Closed

compwron mentioned this issue Jun 17, 2019

Update to factory bot doubleunion/arooo#352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

factory_girl_rails/factory_bot_rails RuntimeError: can't modify frozen Array #247

factory_girl_rails/factory_bot_rails RuntimeError: can't modify frozen Array #247

torntrousers commented Oct 26, 2017 •

edited

Loading

joshuaclayton commented Oct 26, 2017

torntrousers commented Oct 26, 2017 •

edited

Loading

joshuaclayton commented Oct 26, 2017

torntrousers commented Oct 26, 2017

joshuaclayton commented Oct 26, 2017

torntrousers commented Oct 26, 2017 •

edited

Loading

torntrousers commented Oct 27, 2017

joshuaclayton commented Oct 27, 2017

JalisoCSP commented Aug 28, 2018

joshuaclayton commented Aug 28, 2018

JalisoCSP commented Aug 28, 2018 •

edited

Loading

joshuaclayton commented Aug 28, 2018

JalisoCSP commented Aug 29, 2018 •

edited

Loading

KelseyDH commented Sep 5, 2018 •

edited

Loading

kirylrb commented Sep 12, 2018

Mohakjuneja commented Oct 10, 2018

JalisoCSP commented Oct 11, 2018

composerinteralia commented Oct 18, 2018

lstone commented Nov 6, 2018

composerinteralia commented Nov 6, 2018

nezirz commented Mar 13, 2019 •

edited

Loading

composerinteralia commented Mar 13, 2019

AlessandroMinali commented Apr 1, 2019

pavkosykh commented Apr 24, 2019

schmijos commented Apr 29, 2019

composerinteralia commented Apr 29, 2019

deepak-sweeten commented Apr 30, 2019

marcelobarreto commented May 25, 2019 •

edited

Loading

mike927 commented Oct 2, 2019

factory_girl_rails/factory_bot_rails RuntimeError: can't modify frozen Array #247

factory_girl_rails/factory_bot_rails RuntimeError: can't modify frozen Array #247

Comments

torntrousers commented Oct 26, 2017 • edited Loading

joshuaclayton commented Oct 26, 2017

torntrousers commented Oct 26, 2017 • edited Loading

joshuaclayton commented Oct 26, 2017

torntrousers commented Oct 26, 2017

joshuaclayton commented Oct 26, 2017

torntrousers commented Oct 26, 2017 • edited Loading

torntrousers commented Oct 27, 2017

joshuaclayton commented Oct 27, 2017

JalisoCSP commented Aug 28, 2018

joshuaclayton commented Aug 28, 2018

JalisoCSP commented Aug 28, 2018 • edited Loading

joshuaclayton commented Aug 28, 2018

JalisoCSP commented Aug 29, 2018 • edited Loading

KelseyDH commented Sep 5, 2018 • edited Loading

kirylrb commented Sep 12, 2018

Mohakjuneja commented Oct 10, 2018

JalisoCSP commented Oct 11, 2018

composerinteralia commented Oct 18, 2018

lstone commented Nov 6, 2018

composerinteralia commented Nov 6, 2018

nezirz commented Mar 13, 2019 • edited Loading

composerinteralia commented Mar 13, 2019

AlessandroMinali commented Apr 1, 2019

pavkosykh commented Apr 24, 2019

schmijos commented Apr 29, 2019

composerinteralia commented Apr 29, 2019

deepak-sweeten commented Apr 30, 2019

marcelobarreto commented May 25, 2019 • edited Loading

mike927 commented Oct 2, 2019

torntrousers commented Oct 26, 2017 •

edited

Loading

torntrousers commented Oct 26, 2017 •

edited

Loading

torntrousers commented Oct 26, 2017 •

edited

Loading

JalisoCSP commented Aug 28, 2018 •

edited

Loading

JalisoCSP commented Aug 29, 2018 •

edited

Loading

KelseyDH commented Sep 5, 2018 •

edited

Loading

nezirz commented Mar 13, 2019 •

edited

Loading

marcelobarreto commented May 25, 2019 •

edited

Loading