Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspec configuration changed from spec/suport to rails_helper.rb #794

Closed
wants to merge 1 commit into from

Conversation

xw19
Copy link

@xw19 xw19 commented Jul 2, 2015

config line in rspec is now added to the rails_helper.rb file so that factor girl methods can be accessed the previously on support/factory_girl.rb which dont work.

@joshuaclayton
Copy link
Contributor

@xw19 I wouldn't actually recommend moving FG configuration into rails_helper itself; instead, I'd require the file explicitly (since the code to require everything from spec/support isn't enabled by default). This seems to better follow "single responsibility principle", since spec/support/factory_girl.rb is the canonical place for FG config. Thoughts?

@xw19
Copy link
Author

xw19 commented Mar 23, 2016

@joshuaclayton I agree but in documentation it should be clearly mentioned to require that file in rails_helper

@composerinteralia
Copy link
Collaborator

See #1141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants