Sends more javascript information back to hoptaod

thoughtbot · Oct 18, 2010 · 49512d1 · 49512d1
1 parent d21754d
commit 49512d1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/features/rails_with_js_notifier.feature b/features/rails_with_js_notifier.feature
@@ -23,7 +23,7 @@ Feature: Install the Gem in a Rails application and enable the JavaScript notifi
       | myapikey | production  | hoptoadapp.com |
     And the notifier JavaScript should provide the following errorDefaults:
       | url                           | component | action |
-      | http://example.com/test/index | test      | index  |
+      | http://example.com:123/test/index | test      | index  |
 
   Scenario: Include the Javascript notifier when enabled using custom configuration settings
     When I generate a new Rails application

diff --git a/features/step_definitions/rails_application_steps.rb b/features/step_definitions/rails_application_steps.rb
@@ -342,14 +342,13 @@ def rails_non_initializer_hoptoad_config_file
   hash = table.hashes.first
 
   document_body = '<html>' + @terminal.output.split('<html>').last
-  document_body.should include("#{host}/javascripts/notifier.js")
 
   response = Nokogiri::HTML.parse(document_body)
   response.css("script[type='text/javascript']:last-child").each do |element|
     content = element.content
 
     hash.each do |key, value|
-      content.should =~ %r{Hoptoad\.setErrorDefaults.*#{key}:'#{value}'}
+      content.should =~ %r{Hoptoad\.setErrorDefaults.*#{key}: "#{value}}m
     end
   end
 end

diff --git a/lib/templates/javascript_notifier.erb b/lib/templates/javascript_notifier.erb
@@ -9,4 +9,9 @@ document.write(unescape("%3Cscript src='" + notifierJsScheme + "<%= host %>/java
   Hoptoad.setKey('<%= api_key %>');
   Hoptoad.setHost('<%= host %>');
   Hoptoad.setEnvironment('<%= environment %>');
+    Hoptoad.setErrorDefaults({
+      url: "<%= request.url %>",
+      component: "<%= controller_name %>",
+      action: "<%= action_name %>"
+  });
 </script>