Auto-update version and bundle number using Git #208
Conversation
|
Turns out, this isn't enough. We need to modify these values in the generated |
|
I have't looked at this closely but there seems to be ways to do that manually http://stackoverflow.com/questions/13323728/update-cfbundleshortversionstring-in-dsym-at-build I'm not sure how I was able to use Hockey with this script without touching the dSYM |
|
@kaishin I modified the script to update the dSYM as well. Can I get a sanity check from @thoughtbot/shell on this script for correctness? |
| @@ -0,0 +1,16 @@ | |||
| GIT=$(sh /etc/profile; which git) | |||
There was a problem hiding this comment.
No shebang because the shell this is run through is set in Xcode.
There was a problem hiding this comment.
Ah, OK. This has more UPPERCASE variable names than I usually see, but that's not really a huge deal.
There was a problem hiding this comment.
Yeah, I meant to lowercase everything. Doing that now.
|
Quick note on this for the future, this same approach doesn't work on OS X. The app refuses to build if the built product has a different build number than the project. |
| @@ -0,0 +1,16 @@ | |||
| GIT=$(sh /etc/profile; which git) | |||
| GIT_RELEASE_VERSION=$(${GIT} describe --tags --always --abbrev=0) | |||
| COMMITS=$(${GIT} rev-list HEAD | wc -l) | |||
There was a problem hiding this comment.
What about calling this NUMBER_OF_COMMITS?
There was a problem hiding this comment.
I have a change staged where I quoted the entire assignment. Should I do both?
There was a problem hiding this comment.
Assignments don't need quoting, but I often quote them anyway because it doesn't hurt. Up to you what you want to do here, the minimum, safe, POSIX, thing would be:
commits=$("$git" rev-list HEAD | wc -l)There was a problem hiding this comment.
Pat and I discovered yesterday that you don't need to quote assignment, ever, in any of the popular shells.
There was a problem hiding this comment.
Note that quoting around "$( ... )" does not mean you don't still have to quote any variables inside.
|
@Keithbsmiley yikes. Should we bail on this entirely? Or should we keep it since Liftoff is still iOS only? |
| fi | ||
| done | ||
|
|
||
| echo "Updated ${TARGET_BUILD_DIR}/${INFOPLIST_PATH}" |
There was a problem hiding this comment.
The curly braces are not required here. Also, echo with variables is very un-portable. I'd suggest
printf "Updated %s/%s\n" "$TARGET_BUILD_DIR" "$INFOPLIST_PATH"There was a problem hiding this comment.
I'm actually ditching the echo, since I don't think it's going to be super useful.
|
I think this is fair to leave in here for now. I think that script may have to differ by platform regardless. But yea that was just meant to be food for thought, since OS X support is a while off if at all. |
| for PLIST in $TARGET_PLIST $DSYM_PLIST | ||
| do | ||
| if [ -f "$PLIST" ] ; then | ||
| /usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${COMMITS}" "$PLIST" |
There was a problem hiding this comment.
Curly brances aren't required on ${COMMITS}.
In general I don't mind when folks want to always use curly braces on all variables, but you should be consistent throughout the script, or only use them when required (like ${GIT_RELEASE_VERSION#*v})
| @@ -0,0 +1,12 @@ | |||
| git=$(sh /etc/profile; which git) | |||
| git_release_version=$("$git" describe --tags --always --abbrev=0) | |||
| commits=$("$git" rev-list head | wc -l | tr -d ' ') | |||
There was a problem hiding this comment.
how about calling this number_of_commits?
|
👍 |
|
I approve the shell. |
|
Very nice. |
| @@ -32,6 +32,8 @@ perform the following configurations: | |||
| * Turn on Static Analysis for the project. | |||
| * Add a build phase shell script that [turns "TODO:" and "FIXME:" into | |||
| warnings][deallocated-todo]. | |||
| * Add a build phase shell script that sets the version and build number | |||
| using respectively the latest Git tag and the number of commits. | |||
There was a problem hiding this comment.
maybe: "sets the version to the latest Git tag and the build number to the number of commits"?
gfontenot
force-pushed
the
rl-version-number
branch
from
cbc7ab2
to
f2a74eb
Compare
This script updates the version info for the build application by modifying the plist in the biuld binary. It also updates the plist for the generated dSYM to ensure that they match. The CFBundleVersion is set based on the number of commits on master The CFBundleShortVersionString is set based on the most recent git tag
gfontenot
force-pushed
the
rl-version-number
branch
from
1c3bc44
to
fd04483
Compare
No description provided.