This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Fix 293, 601: STI subclassing overwrites options #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When using STI, and when 'config.cache_classes = true', then the STI subclass that gets loaded last will overwrite the options for the others. This is due to using Rails class_attribute with a mutable hash. Solution: dup the hash.
|
Looks good. Lets get it added. |
|
+1 |
|
Closing in a week unless someone contributes a test. Thanks, |
|
The problem appears when using Single Table Inheritance and 'config.cache_classes = true'. Does anyone have a suggestion how to test this? |
|
I would say this is quite tricky to test, and there's already someone confirming the fix in #601. So I'm merging this in. |
sikachu
added a commit
that referenced
this pull request
Oct 21, 2011
Fix 293, 601: STI subclassing overwrites options
This was referenced Oct 21, 2011
|
Hi, is there any reason stopping this fix for being released? This pull request was accepted the same day the last version was released, but just after that... 3 months ago! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When using STI, and when 'config.cache_classes = true', then
the STI subclass that gets loaded last will overwrite the options for
the others. This is due to using Rails class_attribute with a mutable
hash.
Solution: dup the hash.
Related issues: #293, #601