latest tagged version still using aws/s3

[sssb]

The latest tagged version is still using the aws/s3 gem, which contradicts the doc changes that have been pushed. Cost me hours of trying to track down what was wrong.

[sikachu]

Sorry about that. We're trying to get some more refactoring into the code base before we push the newer version.

[sssb]

No worries ... hopefully if someone else is having the same problem they'll at least see this until it's fixed.

This works:

gem 'paperclip', :git => 'git://github.com/thoughtbot/paperclip.git'

[akil-rails]

A couple of hours could have got saved if I would have seen this earlier ..

[sikachu]

The documentation for master is reflecting what's In master. That's the way it is. If you want a documentation for v2.4.5, you can view it by changing the tag.

[jyurek]

This is how github works. The documentation in master is what's in master. It's not necessarily the documentation for the latest released gem.

[timesx2]

You're absolutely right, if the master differs in such a significant way, why is the master not telling people to pull the master branch. We spent three hours trying to figure out what went wrong yesterday, until we saw this.

[timesx2]

And I'm going to have to call BS on the This is how github works. The documentation in master is what's in master. It's not necessarily the documentation for the latest released gem.

A LOT of people put instructions for different versions in master, because it's where everyone goes to look at the instructions.

[radar]

Bros, chill. No need for this level of angst. It helps nobody. Remember: this is Ruby-land, not PHP-land. Nobody called you a moron, and nobody is thinking that you are a moron. Let's all be respectable.

I'm sure that jyurek and sikachu know how GitHub works, given that they are both prolific contributors to the thoughtbot and rails repositories. They've also been using GitHub since April 2008. Please give them the benefit of the doubt in this regard.

The documentation, as was pointed out earlier, is on the specific tag's GitHub page. This is the page for the v2.4.5 tag. It should always be assumed that the master README is for the master branch, unless otherwise expressly stated.

You made a mistake, and that's OK. People do that sometimes. Just please don't take out your frustrations on the people who are providing you with help during their free time, yeah?

<3 Ryan

[sssb]

I absolutely did not make a mistake. I followed the directions in MASTER, which were to pull the latest tagged version. The latest tagged version, however, has a different dependency than MASTER. How is that my mistake?

[chriscarey]

No one may have called him that, but a few of you are pretty damn condescending. That aside, you need to at least read the issues people are having before you chime in with you unsolicited opinion. Here's what happened to me last night.

I started a new rails project. I wanted to user paperclip.

1. I went to github.com/thoughtbot/paperclip
2. I saw this line in the instructions in the master branch gem "paperclip", "~> 2.4"
3. Signified to me that the latest tagged version and the master were the same, or the instructions for master would've
   said to pull master explicitly like every other repository owner does.
4. I also saw this line in the instructions for master : You may also choose to store your files using Amazon's S3 service. To do so, include the aws-sdk gem in your Gemfile:
5. I set up everything in my project and, wow, an unitialized constant error related to AWS. I go searching through the code and can't see what's wrong, so I remove the AWS-SDK gem and try everything again.
6. I get a weird error message telling me I need the AWS/S3 gem. But wait! The docs told me AWS-SDK, so I check my Gem lock file to see what version I pulled. Yep. 2.4.5. That's the last tagged version and the docs in master told me to pull ~2.4, so something's wrong.
7. Finally, I open up the locally installed gem and see it is requiring the S3 gem. So then, I compare 2.4.5 to master and find out, oh, they're not the same.
8. Weird I think, since master says to pull ~2.4.

Time wasted, 1.5 hours.

But obviously, that's my mistake since 'jyurek and sikachu know how GitHub works, given that they are both prolific contributors to the thoughtbot and rails repositories. They've also been using GitHub since April 2008' and I should just give them the benefit of the doubt when they push a doc change but don't update the installation instructions since they differ from 2.4.5 for the time being.

[jyurek]

Look, guys, I'm sorry you spent a bunch of time on this. I feel for you, I really do. But because master is were active development is happening, you can't (or, well, shouldn't) assume that anything is perfect. You were using a released (tagged) gem, not master.

[chriscarey]

Yeah, we're all plainly aware of what version we're using, we only ended up using it because your docs are wrong. What we're saying -- and it's amazing you guys can't see this -- is that the MASTER docs should not have this line:

gem "paperclip", "~> 2.4"

Because that linke conflicts with this line:

You may also choose to store your files using Amazon's S3 service. To do so, include the aws-sdk gem in your Gemfile:

That is what's causing everyone trouble. You make it seem like master and ~2.4 are the same, and they're not.

Just answer this -- why tell people to pull ~2.4 in the master docs if the rest of the master doc contradicts what has to happen in ~2.4 in regard to s3 dependency? Three people have been screwed by that one line, that you know of. Why not just make it clear?

[jyurek]

For the same reason code may be broken in master. It's development. Stuff gets overlooked. It's master, it's in flux.

Anyway, I've changed the README. FWIW, in the future, patches are more likely to get accepted for things like this.