Skip to content
This repository has been archived by the owner on Mar 2, 2018. It is now read-only.

More of a question than an issue #164

Closed
iryanclarke opened this issue Dec 3, 2014 · 7 comments
Closed

More of a question than an issue #164

iryanclarke opened this issue Dec 3, 2014 · 7 comments

Comments

@iryanclarke
Copy link

I absolutely love Refills and the whole Bourbon family, and I want to contribute a new component, but I am a bit confused how develop a new one using this stack.

I'm completely comfortable doing the SASS/HTML scaling and development, I'm just confused how to set up/view my development changes!

Any help is appreciated, thanks! :)

@Magnus-G
Copy link
Contributor

Magnus-G commented Dec 3, 2014

@iryanclarke the best thing to do is:

  1. Discuss the component here first. Just to make sure it fits and that we're not building it already!
  2. Take a look at the code in the Refills repo. Try to mimic the way we do it in your code. Variables on top etc, etc.
  3. Send a PR and we'll discuss it! Most probably we'll poke around with it a bit together to make sure it fits all the standards.

@iryanclarke
Copy link
Author

@Magnus-G

  1. I'm thinking of doing a simple responsive hero unit with a video background that can have a placeholder image used while the video loads, and be able to just show the placeholder at mobile sizes. (Similar to the current hero unit)
  2. I'll tinker around with it, and start with the image hero unit as a start
  3. Will do!

@Magnus-G
Copy link
Contributor

Magnus-G commented Dec 3, 2014

@iryanclarke very nice! Go for it!

@sqlninja
Copy link

@iryanclarke any luck with the video hero unit, I was pondering on doing one as well...

@iryanclarke
Copy link
Author

I'm nearly done it, just polishing it up! :P Still need to commit it into my forked repo :V

@sqlninja
Copy link

@iryanclarke awesome, please let me know when it's available, I would love to have a look...

@iryanclarke
Copy link
Author

I'll let you know, school is bearing down hard so I'll do it when I can!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants