Skip to content
This repository has been archived by the owner on Mar 2, 2018. It is now read-only.

Move image files into refills repo #75

Closed
iainbeeston opened this issue May 26, 2014 · 2 comments
Closed

Move image files into refills repo #75

iainbeeston opened this issue May 26, 2014 · 2 comments

Comments

@iainbeeston
Copy link

Would it be a good idea to move the image files used by refills (eg. in templates and linked to by stylesheets) into the refills project itself, then have the generators copy them into the assets directory on import?

Advantages

  • Easier to serve images from a CDN
  • Easier to replace stock images with custom ones
  • Generated code works without accessing the internet (ie. faster feature tests and more portable)

Disadvantages

  • Increases the size of the gem

Would that make sense? @Magnus-G they're your files, would it be ok with you to pull them into refills?

@Magnus-G
Copy link
Contributor

Yeah! I'll do that now.

@Magnus-G
Copy link
Contributor

Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants