Quote view names #188
Merged
Quote view names #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 7, 2017
|
|
||
| Search.connection.drop_view :'scenic."search in a haystack"' | ||
|
|
||
| silence_stream(STDOUT) { eval(output) } |
There was a problem hiding this comment.
The use of eval is a serious security risk.
houndci-bot
reviewed
Feb 7, 2017
|
|
||
| Search.connection.drop_view :'scenic."search in a haystack"' | ||
|
|
||
| silence_stream(STDOUT) { eval(output) } |
There was a problem hiding this comment.
The use of eval is a serious security risk.
houndci-bot
reviewed
Feb 7, 2017
| it "dumps a create_view for a view in the database" do | ||
| view_definition = "SELECT 'needle'::text AS haystack" | ||
| Search.connection.execute( | ||
| "CREATE SCHEMA scenic; SET search_path TO scenic, public") |
There was a problem hiding this comment.
Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
houndci-bot
reviewed
Feb 7, 2017
| it "dumps a create_view for a view in the database" do | ||
| view_definition = "SELECT 'needle'::text AS haystack" | ||
| Search.connection.execute( | ||
| "CREATE SCHEMA scenic; SET search_path TO scenic, public") |
There was a problem hiding this comment.
Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
houndci-bot
reviewed
Feb 7, 2017
|
|
||
| Search.connection.drop_view :'"search in a haystack"' | ||
|
|
||
| silence_stream(STDOUT) { eval(output) } |
There was a problem hiding this comment.
The use of eval is a serious security risk.
houndci-bot
reviewed
Feb 7, 2017
|
|
||
| Search.connection.drop_view :'"search in a haystack"' | ||
|
|
||
| silence_stream(STDOUT) { eval(output) } |
There was a problem hiding this comment.
The use of eval is a serious security risk.
houndci-bot
reviewed
Feb 7, 2017
| context "with views using unexpected characters in name" do | ||
| it "dumps a create_view for a view in the database" do | ||
| view_definition = "SELECT 'needle'::text AS haystack" | ||
| Search.connection.create_view '"search in a haystack"', sql_definition: view_definition |
houndci-bot
reviewed
Feb 7, 2017
| context "with views using unexpected characters in name" do | ||
| it "dumps a create_view for a view in the database" do | ||
| view_definition = "SELECT 'needle'::text AS haystack" | ||
| Search.connection.create_view '"search in a haystack"', sql_definition: view_definition |
houndci-bot
reviewed
Feb 7, 2017
| @@ -43,9 +43,9 @@ def to_scenic_view(result) | |||
| namespace, viewname = result.values_at "namespace", "viewname" | |||
|
|
|||
| if namespace != "public" | |||
| namespaced_viewname = "#{namespace}.#{viewname}" | |||
| namespaced_viewname = "#{pg_identifier(namespace)}.#{pg_identifier(viewname)}" | |||
houndci-bot
reviewed
Feb 7, 2017
| @@ -43,9 +43,9 @@ def to_scenic_view(result) | |||
| namespace, viewname = result.values_at "namespace", "viewname" | |||
|
|
|||
| if namespace != "public" | |||
| namespaced_viewname = "#{namespace}.#{viewname}" | |||
| namespaced_viewname = "#{pg_identifier(namespace)}.#{pg_identifier(viewname)}" | |||
|
Closes #172 |
calebhearth
force-pushed
the
quote-view-names
branch
from
6aee010
to
6ceb522
Compare
derekprior
reviewed
Feb 10, 2017
| @@ -54,6 +54,11 @@ def to_scenic_view(result) | |||
| materialized: result["kind"] == "m", | |||
| ) | |||
| end | |||
|
|
|||
| def pg_identifier(name) | |||
| return name if name =~ /^[a-zA-Z_][a-zA-Z0-9_]*$/ | |||
There was a problem hiding this comment.
Can we not safely quote the identifier in any case?
There was a problem hiding this comment.
Removing this line caused double quoting in in-memory representations of the names (failing tests) and in the SQL dump (failing more tests, and breaking things). I wasn't able to fix that in ~an hour, so I reverted my attempts.
|
I tried removing this and it ended up causing double quoting because we'd quote on the way out of the db and when it goes in. I think it's only code, but it does break the scheme dump.
… On Feb 9, 2017, at 7:34 PM, Derek Prior ***@***.***> wrote:
@derekprior commented on this pull request.
In lib/scenic/adapters/postgres/views.rb:
> @@ -54,6 +54,11 @@ def to_scenic_view(result)
materialized: result["kind"] == "m",
)
end
+
+ def pg_identifier(name)
+ return name if name =~ /^[a-zA-Z_][a-zA-Z0-9_]*$/
Can we not safely quote the identifier in any case?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
derekprior
approved these changes
Mar 7, 2017
calebhearth
force-pushed
the
quote-view-names
branch
2 times, most recently
from
29bfad8
to
a56338c
Compare
calebhearth
force-pushed
the
quote-view-names
branch
from
a56338c
to
b46e5ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.