Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate_confirmation_of does not work for integer columns #865

Closed
dillonwelch opened this issue Dec 17, 2015 · 3 comments
Closed

validate_confirmation_of does not work for integer columns #865

dillonwelch opened this issue Dec 17, 2015 · 3 comments

Comments

@dillonwelch
Copy link

When using the confirmation validation on an integer value, the validate_confirmation_of matcher does not work as it appears to use string values.

@mcmire
Copy link
Collaborator

mcmire commented Dec 18, 2015

Thanks for the report. I'm not sure when I'll get to this (a PR is encouraged), so I'll keep this open in the meantime.

@kheppenstall
Copy link

Confirmed this bug. No error with strings but had the following problem with integers:

Validation:

validates_confirmation_of :unit_price_in_cents

Test:

it { is_expected.to validate_confirmation_of(:unit_price_in_cents) }

Error:
screen shot 2017-04-06 at 11 40 50 am

@mcmire
Copy link
Collaborator

mcmire commented May 6, 2020

Hey folks. In an effort to lighten our load as maintainers and be able to serve you better in the future, the shoulda-matchers team is working on cleaning out the cobwebs in this repo by pruning the backlog. As there are few of us, there are a lot of items that will simply never earn our attention in a reasonable time frame, and rather than giving you an empty promise, we think it makes more sense to focus on more recent issues. That means, unfortunately, that we must close this issue.

Don't take this the wrong way: our aim is not to diminish the effort people have made or dismiss problems that have been raised. If you feel that we should reopen this issue, then please let us know so that we can reprioritize it. Thanks!

@mcmire mcmire closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants