vim-rspec sending g:rspec_command command to shell rather than vim

[geoffharcourt]

I updated vim-rspec this weekend (since commit 4c637bd) and have noticed what seems to be a regression. I am using Dispatch, but the problem can be replicated without Dispatch.

I noticed the issue when I would attempt to run specs, and would get this output

Dispatch rspec spec
zsh:1: command not found: Dispatch

shell returned 127

Press ENTER or type command to continue

Dispatch rspec {spec} (my complete value for g:rspec_command was getting returned as an invalid zsh command. If I change my g:rspec_command to just rspec {spec} (with no exclamation point before the rspec command), then vim-rspec executes the specs.

It looks like vim-rspec is just passing whatever g:rspec_command is on to the shell rather than to vim. If I attempt to use the default and not specify a custom command, vim-rspec works as expected. I'm not sure if after this new change to allow simultaneous definitions of g:rspec_command and g:rspec_runner in 4c637bd that there's a new configuration that wasn't reflected in the docs or not.

[geoffharcourt]

One more item: if I rewind to the previous commit (94a256b), the problem is resolved.

[kbredemeier]

Same problem for me using vim-slime

[gylaz]

I've reverted 4c637bd as I realized that it wasn't thought through well enough.

[geoffharcourt]

@gylaz, thanks very much for the quick fix.

[chibicode]

👍

[neektza]

This is still happening for me when using vim-rspec and vim-dispatch together.

In my .vimrc I have:

let g:rspec_command = "Dispatch rspec {spec}"
let g:rspec_runner = "os_x_iterm"

The whole command (Dispatch rspec spec/models/users_spec.rb) gets dumped to the console when it should be run by Vim instead.

When using only vim-dispatch (Dispatch rspec %) everything works fine.

[tomaszwojcik]

Same issue as @neektza. Whole Dispatch command is send to the console on MacVim GUI, however on terminal Vim it works fine.

[ainformatico]

Same issue here.

[keith]

I was able to reproduce this error with the commands mentioned by @neektza running in MacVim. The command being created is:

!/path/to/vim-rspec/bin/os_x_iterm 'Dispatch rspec {spec}'

We should be letting dispatch handle all of this. Then the command would just be:

Dispatch rspec {spec}

[gylaz]

I've been thinking about this, and I think a reasonable solution is not to default a g:rspec_runner, but to force the user to set it if they want to use one. This would allow for the use case of this issue.

[kurioscreative]

Was there ever a resolution of this issue? I can confirm that it is still happening for me on Macvim and iTerm2.