Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync failed error when fetching commits of deleted branch #124

Closed
wants to merge 18 commits into from

Conversation

ATPEEE
Copy link
Contributor

@ATPEEE ATPEEE commented Jun 7, 2022

Our team fix sync failed error when fetching commits of deleted branch as the following ideas:
#114 (comment)

Also, we refactor GithubPipelineService following the picture below:
WeChatWorkScreenshot_b00388a9-c06f-413d-a35f-1a7afff5b586

We extract several services from GithubPipelineService to make it independent.
Thus, we add some unit tests according to new services and fix GithubPipelineServiceTest.

@codecov-commenter
Copy link

Codecov Report

Merging #124 (2fe101a) into main (3b70143) will decrease coverage by 0.04%.
The diff coverage is 94.01%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   94.26%   94.22%   -0.05%     
==========================================
  Files          88       92       +4     
  Lines        4306     4344      +38     
  Branches      251      255       +4     
==========================================
+ Hits         4059     4093      +34     
- Misses        124      125       +1     
- Partials      123      126       +3     
Impacted Files Coverage Δ
...etrik/project/domain/repository/BuildRepository.kt 80.95% <ø> (ø)
...domain/service/githubactions/ExecutionConverter.kt 100.00% <ø> (ø)
...project/domain/service/githubactions/RunService.kt 88.57% <ø> (ø)
...t/infrastructure/github/feign/GithubFeignClient.kt 23.07% <ø> (ø)
...infrastructure/jenkins/feign/JenkinsFeignClient.kt 50.00% <ø> (ø)
...n/metrik/project/rest/SynchronizationController.kt 56.66% <ø> (ø)
...in/metrik/project/rest/validation/EnumValidator.kt 33.33% <0.00%> (ø)
...astructure/github/feign/response/BranchResponse.kt 50.00% <50.00%> (ø)
...ject/domain/service/githubactions/BranchService.kt 94.44% <94.44%> (ø)
...domain/service/githubactions/PipelineRunService.kt 94.44% <94.44%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbddbc...2fe101a. Read the comment docs.

@kevinlzw
Copy link
Collaborator

kevinlzw commented Jun 9, 2022

Approved

@zhe-zhao
Copy link
Collaborator

Hey @ATPEEE found a few conflicts after the last review. Could you please have a look?

@ATPEEE
Copy link
Contributor Author

ATPEEE commented Jun 13, 2022

Hey @ATPEEE found a few conflicts after the last review. Could you please have a look?

Hi, because roujing forked my repo, so my changes has been involved in.
please look at #125
So I will close this PR.

@ATPEEE ATPEEE closed this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants