-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sync failed error when fetching commits of deleted branch #124
Conversation
…pelineCommitServiceTest
…pelineCommitServiceTest
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 94.26% 94.22% -0.05%
==========================================
Files 88 92 +4
Lines 4306 4344 +38
Branches 251 255 +4
==========================================
+ Hits 4059 4093 +34
- Misses 124 125 +1
- Partials 123 126 +3
Continue to review full report at Codecov.
|
Approved |
Hey @ATPEEE found a few conflicts after the last review. Could you please have a look? |
Our team fix sync failed error when fetching commits of deleted branch as the following ideas:
#114 (comment)
Also, we refactor GithubPipelineService following the picture below:
We extract several services from GithubPipelineService to make it independent.
Thus, we add some unit tests according to new services and fix GithubPipelineServiceTest.