Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(enhancement)solve the problem of progress bar don't display properly #125

Merged
merged 28 commits into from
Jun 13, 2022

Conversation

RoujingLiu
Copy link

#95
Divide the fetching progress into 3 "steps" and show: fetching new runs, fetching in-progress runs and fetching commits. Remove redundant emitCb during mapping of runs and commits.
Fix the problem of SSE cached due to the webpack.
Fix the problem of tests' name and services' name don't match.

yuan.gu and others added 26 commits May 30, 2022 14:59
@LixingSun LixingSun requested a review from zhe-zhao June 8, 2022 13:40
@codecov-commenter
Copy link

Codecov Report

Merging #125 (acd46a4) into main (3b70143) will decrease coverage by 0.06%.
The diff coverage is 93.97%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   94.26%   94.20%   -0.07%     
==========================================
  Files          88       93       +5     
  Lines        4306     4380      +74     
  Branches      251      258       +7     
==========================================
+ Hits         4059     4126      +67     
- Misses        124      126       +2     
- Partials      123      128       +5     
Impacted Files Coverage Δ
...n/metrik/project/constant/GithubActionConstants.kt 0.00% <0.00%> (ø)
...etrik/project/domain/repository/BuildRepository.kt 80.95% <ø> (ø)
...domain/service/githubactions/ExecutionConverter.kt 100.00% <ø> (ø)
...t/infrastructure/github/feign/GithubFeignClient.kt 23.07% <ø> (ø)
...infrastructure/jenkins/feign/JenkinsFeignClient.kt 50.00% <ø> (ø)
...n/metrik/project/rest/SynchronizationController.kt 56.66% <ø> (ø)
...in/metrik/project/rest/validation/EnumValidator.kt 33.33% <0.00%> (ø)
...astructure/github/feign/response/BranchResponse.kt 50.00% <50.00%> (ø)
...project/domain/service/githubactions/RunService.kt 89.58% <88.88%> (ø)
...ject/domain/service/githubactions/BranchService.kt 94.44% <94.44%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbddbc...acd46a4. Read the comment docs.

@hyrepo
Copy link
Collaborator

hyrepo commented Jun 15, 2022

@all-contributors please add @RoujingLiu for code

@allcontributors
Copy link
Contributor

@hyrepo

I've put up a pull request to add @RoujingLiu! 🎉

@hyrepo
Copy link
Collaborator

hyrepo commented Jun 15, 2022

@all-contributors please add @RoujingLiu for code

@allcontributors
Copy link
Contributor

@hyrepo

I've put up a pull request to add @RoujingLiu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants