Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent ignore for scoped file patterns #122

Closed
harinee opened this issue Jun 13, 2019 · 3 comments
Closed

Permanent ignore for scoped file patterns #122

harinee opened this issue Jun 13, 2019 · 3 comments
Assignees

Comments

@harinee
Copy link
Collaborator

harinee commented Jun 13, 2019

  1. Create configs in Talisman tool to maintain a list of files/file patterns, categorised by tech scope. For example, Golang scope contains pkg, lock files etc.
  2. Add capability to .talismanrc to accept 'scope to ignore' from users. For example, they can define scope: Golang, bash, Java
  3. Based on the scope selected, Talisman will ignore the file patterns defined in the tool's config. The rest of the files will be scanned in the same way as it does today

This way, we permanently ignore the files that are expected to contain values that would otherwise fail Talisman validations (such as, binary, hex encoded, high shannon entropy etc.) but can be considered harmless since they wouldn't be a place where users can accidentally let secrets out.

Can you suggest an initial list of configs to start with?
@vhasus @aaquibzama-tw @mabaritw @rrajagop @subhrajitroy @jaydeepc and @ our other friends of Talisman

Thanks!

@svishwanath-tw
Copy link
Collaborator

svishwanath-tw commented Jul 10, 2019

go.mod and go.sum for golang with GO111MODULE=on
Godeps/Godeps.json and vendor fo godeps users
Gopkg.toml, Gopkg.lock, and vendor/ for dep users
glide.yaml, glide.lock and 'vendor/forglide` users

@harinee harinee assigned harinee and unassigned harinee and aaquibzama-tw Sep 29, 2019
@harinee
Copy link
Collaborator Author

harinee commented Oct 1, 2019

@svishwanath-tw Am closing the issue, but this is pending a release. Could you please release this?

@svishwanath-tw
Copy link
Collaborator

@harinee : released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants