Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work for multiple commits. #45

Closed
mariusz-zawadzki opened this issue Apr 20, 2018 · 2 comments
Closed

Does not work for multiple commits. #45

mariusz-zawadzki opened this issue Apr 20, 2018 · 2 comments
Labels
duplicate

Comments

@mariusz-zawadzki
Copy link

Talisman blocked default README.md from "create-react-app" but allowed to push when I cleared README.md in second commit.

Example here:
https://github.com/mariusz-zawadzki/montessori-teacher-tools/commits/master

Steps to recreate:

  1. Init a repo
  2. add a file that has content that is not allowed.
  3. git commit
  4. git push (get failure)
  5. Clear/fix content of said file.
  6. git commit
  7. git push (success, expected failure)
@AikoPath
Copy link

Known issue.
Addressed by #16 bug: talisman allows push when user adds a commit to delete the added secret

@harinee
Copy link
Collaborator

harinee commented Aug 2, 2019

Marking as duplicate of #16
Let's track that issue

@harinee harinee closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mariusz-zawadzki @harinee @AikoPath