Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus: interface to implement 'qdbus io.thp.billboard / render' #2

Merged
merged 2 commits into from
Mar 26, 2015

Conversation

teleshoes
Copy link
Contributor

No description provided.

@teleshoes teleshoes force-pushed the feature_dbus branch 2 times, most recently from 25b12ba to fac69a0 Compare March 17, 2015 03:49
@teleshoes teleshoes changed the title dbus: interface to implement 'qdbus --system io.thp.billboard / render' dbus: interface to implement 'qdbus io.thp.billboard / render' Mar 17, 2015
<provide>
<credential name="control" />
<credential name="access" />
<dbus name="io.thp.billboard" own="control" bus="system">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above you say QDBusConnection::sessionBus().registerService(DBUS_SERVICE);, but you say bus="system" here -- I guess it should be the session bus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! i originally used the system bus since its generally more reliable, but i didnt realize that the only reason it worked was my /etc/dbus-1/system.conf.
apparently, i forgot to change it everywhere

@thp
Copy link
Member

thp commented Mar 21, 2015

After renaming the D-Bus method and everything added in the patch from render to refresh, maybe also add a simple billboard-refresh subdirectory (qmake SUBDIRS) that installs a small shell script called billboard-refresh to /usr/bin/ that does the D-Bus call via dbus-send.

Or if you want to go all the way, name the directory billboard-cli, the script also billboard-cli and have it accept a sub-command as first parameter, and for now just implement the refresh subcommand to call the D-Bus method. In this case, it should probably not be a script, but can be a (non-GUI) Qt application and use QtDBus for calling the method.

What do you think?

@teleshoes
Copy link
Contributor Author

sure, ill add billboard-cli. as for render vs refresh, i think render is more appropriate. how about having refresh as a synonym in the dubs wrapper script?

@teleshoes
Copy link
Contributor Author

i prefer to target /opt/billboard/bin for consistency. i hate it when programs install some executables in one dir and some in another, even though its somewhat more justifiable for binaries vs scripts

@teleshoes teleshoes force-pushed the feature_dbus branch 2 times, most recently from 5e6cc71 to e667cdf Compare March 21, 2015 07:59
@teleshoes
Copy link
Contributor Author

i decided a script was more appropriate than a QT app for a glorified dbus wrapper. billboard-refresh is too specific, though {if the change-property dbus method is added, it will be nice to have a place to put it, e.g.: billboard-cli --set-prop PROP VAL}

@thp
Copy link
Member

thp commented Mar 22, 2015

Added some more comments. After that, this should be ready to go in as well.

thp added a commit that referenced this pull request Mar 26, 2015
dbus: interface to implement 'qdbus io.thp.billboard / render'
@thp thp merged commit d804c7d into harmattan:master Mar 26, 2015
@thp
Copy link
Member

thp commented Mar 26, 2015

Merged, thanks!

@teleshoes
Copy link
Contributor Author

woo! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants