-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbus: interface to implement 'qdbus io.thp.billboard / render' #2
Conversation
25b12ba
to
fac69a0
Compare
<provide> | ||
<credential name="control" /> | ||
<credential name="access" /> | ||
<dbus name="io.thp.billboard" own="control" bus="system"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above you say QDBusConnection::sessionBus().registerService(DBUS_SERVICE);
, but you say bus="system"
here -- I guess it should be the session bus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep! i originally used the system bus since its generally more reliable, but i didnt realize that the only reason it worked was my /etc/dbus-1/system.conf.
apparently, i forgot to change it everywhere
After renaming the D-Bus method and everything added in the patch from Or if you want to go all the way, name the directory What do you think? |
sure, ill add billboard-cli. as for render vs refresh, i think render is more appropriate. how about having refresh as a synonym in the dubs wrapper script? |
i prefer to target /opt/billboard/bin for consistency. i hate it when programs install some executables in one dir and some in another, even though its somewhat more justifiable for binaries vs scripts |
5e6cc71
to
e667cdf
Compare
i decided a script was more appropriate than a QT app for a glorified dbus wrapper. billboard-refresh is too specific, though {if the change-property dbus method is added, it will be nice to have a place to put it, e.g.: billboard-cli --set-prop PROP VAL} |
Added some more comments. After that, this should be ready to go in as well. |
dbus: interface to implement 'qdbus io.thp.billboard / render'
Merged, thanks! |
woo! thanks! |
No description provided.