Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--gc-cache does not delete unused keys from redis db #743

Closed
trevorshannon opened this issue Dec 20, 2022 · 2 comments · Fixed by #746
Closed

--gc-cache does not delete unused keys from redis db #743

trevorshannon opened this issue Dec 20, 2022 · 2 comments · Fixed by #746

Comments

@trevorshannon
Copy link
Contributor

trevorshannon commented Dec 20, 2022

When using a redis cache, the --gc-cache option successfully removes old entries, but does not delete old keys (despite claiming to do so). This seems to be due to a string/bytes type issue somewhere around here.

When deleting unused keys, the system attempts to remove e.g. "guid:b'27687e4f702f8547973bc60451b4f1539ee3d428'" instead of "guid:27687e4f702f8547973bc60451b4f1539ee3d428"

@thp
Copy link
Owner

thp commented Dec 21, 2022

Yeah, the problem with the Redis support is that at least I don't test it regularly.

It was added by @scottmac in #491. I don't have an overview of how popular the Redis support is.

If it's not easy to test/verify, then maybe eventually removing the Redis support is a good idea?

(cc'd @scottmac to chime in)

@scottmac
Copy link
Contributor

scottmac commented Dec 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants