Error when piping to less

[polyzen]

Sometimes a stack trace occurs after quitting less (apparently only when there's actual output):

~ > urlwatch |less                                                                     
Traceback (most recent call last):
  File "/usr/bin/urlwatch", line 375, in <module>
    main(parser.parse_args())
  File "/usr/bin/urlwatch", line 342, in main
    report.finish()
  File "/usr/lib/python3.5/site-packages/urlwatch/handler.py", line 128, in finish
    ReporterBase.submit_all(self, self.job_states, duration)
  File "/usr/lib/python3.5/site-packages/urlwatch/reporters.py", line 89, in submit_all
    cls(report, cfg, job_states, duration).submit()
  File "/usr/lib/python3.5/site-packages/urlwatch/reporters.py", line 304, in submit
    print(self._green(line))
BrokenPipeError: [Errno 32] Broken pipe
zsh: exit 1     urlwatch | 
zsh: done       less

urlwatch 2.2
less 481
Arch Linux Arm

[brbsix]

Placing the following code near the top of urlwatch will suppress the error:

import signal

# ignore broken pipe
signal.signal(signal.SIGPIPE, signal.SIG_DFL)

Maybe @thp can add it?

Upon further examination, it appears this will also suppress any SIGPIPE on a socket. Not sure if this behavior will pose a problem.

[thp]

Looks like when a SIGPIPE for a socket is received, the network send will return an error, so that should be good. I guess I'll add this to Git now.

[polyzen]

Glad this could get sorted so quickly! Thank you both.

[DerEineDa]

I get this on my Fedora 24 workstation after installing urlwatch with pip:

$ urlwatch   File "/usr/bin/urlwatch", line 93
  ...
  ^
SyntaxError: invalid syntax

because of the "..." in commit 9c675de .

Edit: Sorry, that seems to be correct python3 syntax.

[thp]

@DerEineDa as you probably have already noticed in your edit, you need to install urlwatch using Python 3's PIP.