Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use parrallel transfer to make it faster #38

Closed
maboiteaspam opened this issue Mar 4, 2014 · 3 comments
Closed

use parrallel transfer to make it faster #38

maboiteaspam opened this issue Mar 4, 2014 · 3 comments

Comments

@maboiteaspam
Copy link
Contributor

Hi,

Seems like the task is sending each file one by one.
Making things much slower than -what it could be-.

This seems confirmed by my tries of the task, and also the source code,

https://github.com/thrashr888/grunt-sftp-deploy/blob/master/tasks/sftp-deploy.js

      async.forEachLimit(files, 1, sftpPut, function (err) {
        // console.log('callback');
        cb(null);
      });

The second parameter with a value=1 means we run a concurrency level of ... 1, sequential.

I have some wheeling to jump into it but i was wondering if there was a concrete reason to not use more concurrency, or if it is definitely a fixable feature.

@thrashr888
Copy link
Owner

I'm not using concurrency because my server does not support it. If there were a config option for this (so I can set it to 1) it would work for me. I believe that's what other SFTP clients do (ie. Transmit).

@maboiteaspam
Copy link
Contributor Author

Did, it in the last pr, you also have an option to switch to 1 if needed.
But i m somehow disapointed the improvements are not amazing.
At least compared to a manual filezilla/whatever/ transfer with the same concurrency level i find the same overall speed, thus i guess the small improvement result is somehow related to my bandwidth which block to 400.
Let s see.

hth.

@thrashr888
Copy link
Owner

I've merged some improvements. Can you pull the latest from master to see if they work well for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants