AbstractCompletableListenableFuture.cancel listener execution thread fix #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves threadly#274 Issue threadly#274 describes where AbstractCompletableListenableFuture.cancel may result in listeners with `SingleThreadIfExecutorMatchOrDone` or `SingleThreadIfExecutorMatch` optimization being executed on the thread canceling the future rather than the expected pool. As commented this minimal overhead is unfortunate considering how corner case this condition is. Which makes me partially reconsider the optimization capability entirely.
|
@lwahlmeier Any thoughts on this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves #274
Issue #274 describes where AbstractCompletableListenableFuture.cancel may result in listeners with
SingleThreadIfExecutorMatchOrDoneorSingleThreadIfExecutorMatchoptimization being executed on the thread canceling the future rather than the expected pool.As commented this minimal overhead is unfortunate considering how corner case this condition is. Which makes me partially reconsider the optimization capability entirely.