Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Update user profile page instructions #419

Merged
merged 1 commit into from Sep 28, 2016

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Sep 27, 2016

Updates the instructions to use the Rails 5 render-anywhere method.

@jayroh @timdiggins What do you think?

Updates the instructions to use the Rails 5 render-anywhere method.
@jayroh
Copy link
Member

jayroh commented Sep 28, 2016

LGTM, man! 👍

@jayroh jayroh merged commit d7b0ad4 into master Sep 28, 2016
@timdiggins
Copy link
Collaborator

@glebm what's the benefit of using this method rather than previous way? If I understand correctly this feature was created for rendering outside controllers rails/rails#18546

(I'm successfully using the previously documented mechanism)

@glebm
Copy link
Collaborator Author

glebm commented Sep 28, 2016

@timdiggins The previous mechanism required the user to include Thredded::ApplicationHelper into the controller that renders the user's profile page, which had a high likelihood of name clashes with main_app (since we use helpers such as user_link).

@glebm
Copy link
Collaborator Author

glebm commented Sep 28, 2016

@timdiggins and yeah, this was created for rendering outside of the controllers and fakes the request environment. But it's OK I guess as we don't use the request environment when rendering these partials.

@timdiggins timdiggins deleted the update-readme-user-posts branch October 3, 2016 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants