Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres/UUID compatability #538

Closed
jvoss opened this issue Mar 7, 2017 · 3 comments
Closed

Postgres/UUID compatability #538

jvoss opened this issue Mar 7, 2017 · 3 comments
Milestone

Comments

@jvoss
Copy link
Contributor

jvoss commented Mar 7, 2017

There are several routes that enforce regex on the post ID, etc being a number 0-9. Can the routes be updated to allow UUIDs if someone is using that instead of integer IDs?

@glebm
Copy link
Collaborator

glebm commented Mar 7, 2017

This seems to be the only block that currently does this, is that right?

scope only: [:show], constraints: { id: positive_int } do
  resources :private_post_permalinks, path: 'private-posts'
  resources :post_permalinks, path: 'posts'
end

We can definitely consider a PR that adds a configuration option such as Thredded.routes_id_constraint.

@jvoss
Copy link
Contributor Author

jvoss commented Mar 7, 2017

That appears to be the only blocking that I am running into at the moment, mostly having to deal with moderation which does use this route.

I'll see if I can create a PR for you soon. Thanks!

@glebm
Copy link
Collaborator

glebm commented Mar 7, 2017

Thank you! All merged, will be out in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants