Errors in master repo

[robsilv]

Hi guys,

This is the first version of the master repo that doesn't work for me when I open it in the latest release build of Dart Editor. I get the following error:

Running pub install ...
Pub install fail, Cannot install 'stats' from Git (https://github.com/financeCoding/stats.dart.git).
Please ensure Git is correctly installed.

It seems to me that the problem is due to an external dependency being introduced for the stats.dart project?

I've written a post on our group outlining what I think should be a core set of principals when updating three.dart: https://groups.google.com/forum/#!topic/three-dart/vf9f3gzM6as

Please let me know what you think!

[nelsonsilva]

Robert, this seems specific to your environment I merged the pull request cause it worked for me. I just ran pub install from the editor and everything worked as expected.
stats.dart was introduced to start benchmarking the project. @mrdoob asked about performance and we should start adding stats for some samples to compare with the js version.
Please file a ticket in the dart google code project or ask around in the dart group.

[robsilv]

Thanks Nelson, adding stats is definitely a good thing. However, in three.js, the stats.js code is added here:

https://github.com/mrdoob/three.js/blob/master/examples/js/Stats.js

i.e. the code is copied over from the Stats.js project into the three.js project, there is no external dependency and the three.js project works "out of the box".

I'm not currently seeing the Stats.dart code within three.dart project, which leads me to think that we've introduced an external dependency here, i.e. users have to know to check out Stats.dart too, otherwise three.dart will be broken for them. Is this not the case?

[nelsonsilva]

No. stats.dart is specified as a dependency in pubspec. So after running pub install stats.dart will be available. No extra step is needed.
Ideally however we'd have stats.dart as a dependency only in the examples that use it but I'm not sure pub install will recurse into each of the examples sub folders to lookup their dependencies so for now we'll keep it as it is.

[robsilv]

Ah ok, so I can see the reference you're referring to here:

https://github.com/threeDart/three.dart/blob/master/pubspec.yaml#L13

But doesn't this still assume that the user has first checked out the stats.dart project and has the files available on their machine? My worry is that yourself and Adam are both very clued up on Dart and are introducing neat stuff, but some of it appears to require a certain level of knowledge in order to get it working (assuming what I've said above is correct), meaning that for the first time, novice users will now be greeted with a project full of errors that they won't know how to resolve.

[nelsonsilva]

No special knowledge is needed. Dart's pub is similar to node.js's npm. You just need to run "pub install" and it will install the dependencies "automagically". Just glance through http://www.dartlang.org/docs/pub-package-manager/ and you'll get the general idea.

[robsilv]

Ok, thanks for the info. So pub automatically downloads the code for you and adds the references? Sounds pretty cool, my only concern with it at the moment is it's not working on my fairly standard Windows 7 laptop, so currently we're failing the "works out of the box" test, even when just considering the 3 of us who are currently actively working on the project. I can't actually get the three.dart project to work at all at the moment, even if I download the stats repo manually. I'm cautious to start using bleeding edge stuff in Dart for this reason; if I can't easily get it working, I think it's safe to assume that lots of other users would have similar problems. I don't want the three.dart repo to change from "it just works" to "it's just another broken GitHub project".

[nelsonsilva]

Ok. I've reverted the commit that added the stats stuff.
I think the problem is that you don't have git installed in your machine. You're either just using eGit or some git frontend and Dart editor is unable to find git.
I'll delay adding stats.dart until it's available from pub.dartlang.org then you won't neet git to get it working.

@financecoding have you submitted stats.dart to pub.dartlang.org ?

[nelsonsilva]

@financecoding http://code.google.com/p/dart/issues/detail?id=5580

[robsilv]

Cool, thanks Nelson. Running through the examples now, all seems to be working nicely. Will update gh-pages and the README to include the new examples shortly!

Just so you know, I'm using the standard windows github client: http://windows.github.com/

[nelsonsilva]

Yep. That's probably the issue. You'd need to be using msysgit or something like that. Basically you need to be able to open a cmd line, run "git" and have it available, which you don't.

[adam-singer]

stats.dart should of already been added to the issue tracker, no worries on the resubmit

[nelsonsilva]

I searched for it and did not find it (crappy issue tracker in google code) perhaps they'll make it better once they see they have dozens of duplicates :P