New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative to root_numpy #404
Comments
@cbrisboi I think the other part of ROOT that is used in in the ROOT minimizers. Is this also a simple fix? |
Since root_numpy is only for file io, this would be (to my mind) somewhat separate from the minimizers. It appears that in the threeML repo(rather than hawc_hal), the only place this code is used is in the VERITASLike plugin, although I am not taking responsibility for that plugin, as I am not a member of VERITAS. |
So this is not the same thing? https://github.com/threeML/threeML/blob/master/threeML/minimizer/ROOT_minimizer.py#L3 |
No, thats using |
Aha! Well, I'm all fine with it, but @ndilalla just did all the root stuff, so he should chime in. |
I am all in for getting rid of |
On github, the only strict dependency is numpy, although if going through conda, which I suspect is preferred, the dependencies are ( using Here is the relevant github page https://github.com/scikit-hep/uproot4
|
Wow. This package is amazing. |
This issue has become stale. Is there an update? We will close in 15 days |
@cbrisboi will there be any progress on this? Otherwise, we need to go ahead and close or assign someone else. |
This issue has become stale. Is there an update? We will close in 15 days |
I was looking at updating
hawc_hal
to useuproot
rather than the old ROOT interface for its.root
file io and saw that a big part of theroot_numpy
dependency is carried over from 3ML via the dependency onthreeML/io/cern_root_utils
. I would generally prefer to stay consistent with file handling between 3ML and hawc_hal. Is there a preference for uproot vs the new ROOT interface? This is already an issue in hawc_hal, see threeML/hawc_hal#42The code looks straightforward to update, but before I run off and implement something that is not preferred, I thought asking would be wise first.
The text was updated successfully, but these errors were encountered: