Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Run tests' step in the Rust/build workflow fails #112

Closed
robvanmieghem opened this issue Feb 15, 2023 · 2 comments
Closed

The 'Run tests' step in the Rust/build workflow fails #112

robvanmieghem opened this issue Feb 15, 2023 · 2 comments
Assignees
Labels
process_wontfix This will not be worked on type_bug Something isn't working
Milestone

Comments

@robvanmieghem
Copy link
Contributor

No description provided.

@robvanmieghem robvanmieghem added the type_bug Something isn't working label Feb 15, 2023
@robvanmieghem robvanmieghem added this to the 0.3.0 milestone Feb 15, 2023
@robvanmieghem robvanmieghem changed the title The Run tests step in the Rust/build workflow fails The **Run tests** step in the Rust/build workflow fails Feb 15, 2023
@robvanmieghem robvanmieghem changed the title The **Run tests** step in the Rust/build workflow fails The 'Run tests' step in the Rust/build workflow fails Feb 15, 2023
@LeeSmet
Copy link
Contributor

LeeSmet commented Feb 23, 2023

Added a branch which fixes an inconsistent use of sudo when working with network namespaces. Other than that, the integration tests set up an entire qsfs stack, which is not really fitting for the repo, but might be useful to test the core functionality for now. This does mean that there are dependencies on 0-db-fs, 0-db, and some third party shell script. Can be solved by implementing the installation of these as a step before executing the actual workflow. I do think this should be implemented in its entirety simply as a bash script instead of an integration test, but alas.

@LeeSmet LeeSmet self-assigned this Feb 27, 2023
@LeeSmet LeeSmet added the process_wontfix This will not be worked on label Feb 28, 2023
@LeeSmet
Copy link
Contributor

LeeSmet commented Feb 28, 2023

Since the unit tests don't actually test zstor but rather qsfs, it has been decided to remove them (done in e4762bb). Dedicated qsfs tests should be added in the qsfs repo instead.

@LeeSmet LeeSmet closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process_wontfix This will not be worked on type_bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants