Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification system for the dashboard #1335

Closed
xmonader opened this issue Oct 1, 2020 · 4 comments
Closed

notification system for the dashboard #1335

xmonader opened this issue Oct 1, 2020 · 4 comments

Comments

@xmonader
Copy link
Collaborator

xmonader commented Oct 1, 2020

allow dashboard to have notifications

more to be spec'd

@xmonader xmonader added this to Todo in grid 2.3 via automation Oct 1, 2020
@xmonader xmonader moved this from Todo to To Start in grid 2.3 Oct 1, 2020
@dmahmouali dmahmouali moved this from To Start to In Progress in grid 2.3 Oct 7, 2020
@AhmedSa-mir
Copy link
Contributor

AhmedSa-mir commented Oct 18, 2020

Current status:

  • Added notification queue tool to be used by services to push notifications to the admin dashboard. Used redis lists to save notifications to be consumed periodically by the frontend. Notification are not persistent that is the user get notified in the UI and these notifications are not saved anywhere. If a service needs to keep an important notification in history it should raise an alert as well.
  • Added service manager running as a server in the threebot rack. This server manages the background services being added to the threebot instance. One can define his own service to run in the background by overriding the job method to be run. Currerntly the service manager is not finished yet. We have some problems on stopping the background services due to gevent. killmethods strange behaviour (and also tried gevent-tasks package but has also problem with stopping tasks)

@AhmedSa-mir
Copy link
Contributor

AhmedSa-mir commented Oct 19, 2020

Update:

  • Removed dependency of our service manager on gevent-tasks because of errors occuring during stopping greenlets that are scheduled but are not currently running. But implemented our service manager using the methodology used in gevent tasks (gevent.spawn_later() + greenlet.link(callback)) instead of gevent spawn and kill which had unexpected behaviour on killing greenlets.
  • Added actors for UI notifications to fetch notifiacations from our notification queue and some changes in the UI but UI still not yet finished.
  • Tested stellar background service and working fine.

TODO:

  • Finish rendering notifications in UI.
  • Code review
  • More testing with different background services.

@dmahmouali
Copy link
Contributor

update:

  • save a bit of notification history by caching the last 10 notifications in another list.
  • enhance UI and added info, working, and error categories.
  • added new background service: DiskCheckService.
  • enhance code.

@AhmedSa-mir AhmedSa-mir moved this from In Progress to Verification in grid 2.3 Oct 26, 2020
@mhost39 mhost39 self-assigned this Oct 26, 2020
@mhost39 mhost39 added this to New in QA-DevOps Team via automation Oct 26, 2020
@mhost39
Copy link
Contributor

mhost39 commented Oct 26, 2020

branch: development
commit: 08cd9c5
image

@mhost39 mhost39 closed this as completed Oct 26, 2020
QA-DevOps Team automation moved this from New to Done Oct 26, 2020
grid 2.3 automation moved this from Verification to Done Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
grid 2.3
  
Done
Development

No branches or pull requests

4 participants