-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need stricter checks for minting #27
Comments
i.e. revert the revert of all these commits. The following point is in relation to v0.2.0 of the farmerbot and might be better of in its own feature, not sure.
|
In addition to the last point, there also needs to be consideration how we can enforce the presence of random wakeups over time in case the farmerbot is running. |
I believe violations 5,6,7, 8 aren't on the farmer, but ZOS should refuse to boot new nodes if these ever happens Is it possible for the farmerbot to expand with after wakeup calls it tries to reserve and deploy on the reported capacity? |
while 5 6 and 8 are indeed not really user errors, the goal of the minting is to mint tokens for useable capacity. If any of these conditions are true, then the node is not useable, and therefore it should not get tokens rewarded. While that is probably not the users fault, the minting doesn't care for that. If such an event should happen, the user can still be reimbursed, just not through the minting. 7 is referring to the fact that the current way in which twins are decoded from the chain data is inherently broken. This is just a problem local to the minting.
I suppose it should be, though if that is implemented there needs to be some mechanism to inform the minting that this failed (which means pushing some data on the chain). |
I see, were there any actual reports from farmers regarding the zos concerning points? Because if so, some updates need to happen in zos, but if not, we can go a head indeed with these updates @robvanmieghem we are waiting for your input to proceed with this |
Not to my knowledge, and there doesn't seem to be any open bugs about this on the zos repo |
Alright, should we have a forum post explaining the upcoming changes ? |
I suppose there needs to be a GEP about it, something for @sabrinasadik to handle when she's back next week |
The extra hour here is currently saving us from fallout due to this bug in farmerbot that was introduced with the random wakeups. Since development of farmerbot has been stalled for some time, it's not clear when we'll be able to deploy a fix. Lets please wait to make this one change in minting until the plan for next version of farmerbot can be carried out. |
@LeeSmet pls add comments here
The text was updated successfully, but these errors were encountered: