Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up contract id by node id and hash #662

Closed
Tracked by #665
renauter opened this issue Apr 10, 2023 · 1 comment
Closed
Tracked by #665

Clean up contract id by node id and hash #662

renauter opened this issue Apr 10, 2023 · 1 comment
Assignees
Labels
type_bug Something isn't working

Comments

@renauter
Copy link
Collaborator

renauter commented Apr 10, 2023

ContractIDByNodeIDAndHash storage map should not reference not existing node contracts.
Also, if such contract exists, the deployment hash in key should be same as deployment hash in contract

Seen on devnet:

  • ContractIDByNodeIDAndHash key [node: 34, hash: "b076d2fcefdbe02f9902870860a66e91"] gives contract id 16672 and this contract does not exist

    image
    image

  • ContractIDByNodeIDAndHash key [node: 28, hash: [128, 48, 56, 48, 97, 52, 54, 51, 49, 50, 100, 52, 54, 50, 102, 54, 50, 97, 52, 52, 97, 99, 48, 97, 54, 100, 53, 48, 98, 99, 99, 52] = "�080a46312d462f62a44ac0a6d50bcc4"] gives contract id 3768 and the deployment hash in this contract [48, 56, 48, 97, 52, 54, 51, 49, 50, 100, 52, 54, 50, 102, 54, 50, 97, 52, 52, 97, 99, 48, 97, 54, 100, 53, 48, 98, 99, 99, 52, 52] = "080a46312d462f62a44ac0a6d50bcc44" does not match

    image

@renauter renauter added the type_bug Something isn't working label Apr 10, 2023
@renauter renauter added this to the 2.4.0 milestone Apr 10, 2023
@renauter renauter self-assigned this Apr 10, 2023
@DylanVerstraete
Copy link
Contributor

Fix deployed and verified on devnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants