Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review numeric fields in models, make sure to choose a proper size and to be consistent #49

Open
sameh-farouk opened this issue Jan 24, 2023 · 0 comments
Assignees
Labels
grid-proxy belongs to grid proxy type_bug Something isn't working
Milestone

Comments

@sameh-farouk
Copy link
Member

Description

The same field in a model would be uint and in another model int or int64 and there is some conversion here and there. we should agree on specific types and use them always.

another thing, I understand that int64 is/should be big enough, but is there any reason to use it vs unsigned type for things like time interval, resources, and entity ids?

Screenshot from 2023-01-24 12-50-48

Screenshot from 2023-01-24 13-53-49

@sameh-farouk sameh-farouk changed the title Review numeric fields in models, make sure to choose a proper type and to be consistent Review numeric fields in models, make sure to choose a proper size and to be consistent Jan 26, 2023
@ramezsaeed ramezsaeed added the type_bug Something isn't working label Feb 16, 2023
@xmonader xmonader transferred this issue from threefoldtecharchive/tfgridclient_proxy Apr 12, 2023
@rawdaGastan rawdaGastan added the grid-proxy belongs to grid proxy label Apr 12, 2023
@xmonader xmonader added this to the later milestone Apr 17, 2023
@Omarabdul3ziz Omarabdul3ziz self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid-proxy belongs to grid proxy type_bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

5 participants