Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mass deployer clean up strategy #715

Closed
Tracked by #683
Eslam-Nawara opened this issue Jan 31, 2024 · 3 comments
Closed
Tracked by #683

Change mass deployer clean up strategy #715

Eslam-Nawara opened this issue Jan 31, 2024 · 3 comments
Assignees
Labels
tfrobot type_feature New feature or request
Milestone

Comments

@Eslam-Nawara
Copy link
Contributor

Is your feature request related to a problem? Please describe

Mass deployer clean up strategy is to remove all deployments of the failed group and rerun the deployer for that group (reported here)

Describe the solution you'd like

A suggestion is to update the deployer to rerun only the failed deployments

@Eslam-Nawara Eslam-Nawara added the type_feature New feature or request label Jan 31, 2024
@Eslam-Nawara Eslam-Nawara self-assigned this Jan 31, 2024
@Eslam-Nawara Eslam-Nawara added this to the 1.0.0 milestone Feb 1, 2024
@Eslam-Nawara Eslam-Nawara mentioned this issue Feb 4, 2024
4 tasks
@Eslam-Nawara
Copy link
Contributor Author

WIP:

  • updated the retry strategy to only redeploy failed deployments.

  • tried to use ListContractsOfProjectName to load deployed contracts from grid instead of keeping state of the deployments, but it doesn't list the contracts deployed just now for some reason, I would be required to wait for some time before I call it, not sure what the expected behavior is.

  • sometimes the created contracts can't be loaded from state at all, with both methods of listing contracts, not sure what is the cause of it

the deployments exist on the playground with the same info

5:30PM INF couldn't load from state error="failed to find deployment  on node 100: not found" deployment=examplevm4 node ID=100 vm=examplevm4
5:30PM INF couldn't load from state error="failed to find deployment  on node 150: not found" deployment=examplevm1 node ID=150 vm=examplevm1
5:30PM INF couldn't load from state error="failed to find deployment  on node 153: not found" deployment=examplevm3 node ID=153 vm=examplevm3
5:30PM INF couldn't load from state error="failed to find deployment  on node 146: not found" deployment=examplevm0 node ID=146 vm=examplevm0
5:30PM INF couldn't load from state error="failed to find deployment  on node 152: not found" deployment=examplevm2 node ID=152 vm=examplevm2

@Eslam-Nawara
Copy link
Contributor Author

Blocked:

  • continued working on updating the redeployment strategy
  • fixed the couldn't load from state problem
  • tested the new strategy and it works as expected

No we need to fix the DeploymentDeployer.BatchDeploy function as it suppose to be not atomic, but it still all deployments fails to deploy any deployment if one of the used networks failed, which is not the expected behavior reported in:

@rawdaGastan
Copy link
Collaborator

Tried to deploy 100 VMs and some of them failed then the only failed deployments got deployed again and it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tfrobot type_feature New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants