Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NewTFPluginClient to use options instead of long list of optional arguments #857

Closed
Tracked by #827
AbdelrahmanElawady opened this issue Feb 26, 2024 · 1 comment
Closed
Tracked by #827

Refactor NewTFPluginClient to use options instead of long list of optional arguments #857

AbdelrahmanElawady opened this issue Feb 26, 2024 · 1 comment
Assignees
@Eslam-Nawara
Labels
grid-client belongs to grid client type_feature New feature or request
Milestone
1.1.0

Comments

@AbdelrahmanElawady
Copy link
Collaborator

Description

Refactor NewTFPluginClient to use options instead of long list of optional arguments
@AbdelrahmanElawady AbdelrahmanElawady added type_feature New feature or request grid-client belongs to grid client labels Feb 26, 2024
@AbdelrahmanElawady AbdelrahmanElawady mentioned this issue Feb 26, 2024
Open
12 tasks
@Eslam-Nawara Eslam-Nawara mentioned this issue Feb 27, 2024
Merged
4 tasks
@xmonader xmonader added this to the 1.1.0 milestone Mar 7, 2024
@AbdelrahmanElawady
Copy link
Collaborator Author

Verified:

NewTFPluginClient now takes optional arguments:

deployer.NewTFPluginClient(
	mnemonic,
	deployer.WithKeyType(peer.KeyTypeSr25519),
	deployer.WithLogs(),
	deployer.WithNetwork("main"),
	deployer.WithTwinCache(),
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eslam-Nawara Eslam-Nawara

Labels
grid-client belongs to grid client type_feature New feature or request
Projects
3.14.x
Status: Done
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@xmonader @rawdaGastan @AbdelrahmanElawady @Eslam-Nawara