Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service worker for PWA #972

Merged
merged 3 commits into from Mar 17, 2020
Merged

Add service worker for PWA #972

merged 3 commits into from Mar 17, 2020

Conversation

chrisly-bear
Copy link
Contributor

Related issue: #407

Added minimal service worker javascript code required to have Chrome (on Desktop) recognize the app as a PWA and make it installable. This allows users to install the app on their desktops and have it behave like a native application.

@dbrgn dbrgn requested a review from lgrahl March 12, 2020 20:12
Copy link
Contributor

@lgrahl lgrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Although we don't really make use of service workers atm, it makes sense to have one as it is a requirement for Chrome PWAs. A couple of comments in-line.

public/manifest.webmanifest Show resolved Hide resolved
public/js/service-worker-registration.js Outdated Show resolved Hide resolved
public/js/service-worker-registration.js Outdated Show resolved Hide resolved
public/js/service-worker-registration.js Outdated Show resolved Hide resolved
Copy link
Contributor

@lgrahl lgrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lgrahl lgrahl merged commit 7bb2ba0 into threema-ch:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants