Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate Limiting issues in Ocelot #1975

Closed
SheruGaur opened this issue Mar 1, 2024 · 6 comments
Closed

Rate Limiting issues in Ocelot #1975

SheruGaur opened this issue Mar 1, 2024 · 6 comments
Assignees
Labels
bug Identified as a potential bug Rate Limiting Ocelot feature: Rate Limiting

Comments

@SheruGaur
Copy link

Rate Limit is not working when period and period timespan values are different. When we are making same value for period and period timespan then it is working for Rate limiting on configured service. In below configuration first case Rate Limiting is working and in second case Rate Limiting is not working.

  1. First Case
    "RateLimitOptions": {
    "ClientWhitelist": ["HOR777"],
    "EnableRateLimiting": true,
    "Period": "10s",
    "PeriodTimespan": 10,
    "Limit": 2
    },
  2. Second Case
    "RateLimitOptions": {
    "ClientWhitelist": ["HOR777"],
    "EnableRateLimiting": true,
    "Period": "10s",
    "PeriodTimespan": 15,
    "Limit": 2
    },
    Please provide the solution because rate Limiting is not working as per Ocelot documentation. Please provide it is product backlog or ongoing issues.
@raman-m
Copy link
Member

raman-m commented Mar 1, 2024

Thanks for reporting to us once again! But this is well-known #1590 bug ❕
And we have open PR #1592 to fix this bug.
Please, be patient! We're planning to fix this bug in Annual 2023 release which dev will start soon...

As a quick fix, define PeriodTimespan value less than (or equal to) Period

@raman-m
Copy link
Member

raman-m commented Mar 1, 2024

Duplicate of #1590

@raman-m raman-m marked this as a duplicate of #1590 Mar 1, 2024
@raman-m raman-m self-assigned this Mar 1, 2024
@raman-m raman-m added bug Identified as a potential bug Rate Limiting Ocelot feature: Rate Limiting labels Mar 1, 2024
@raman-m
Copy link
Member

raman-m commented Mar 1, 2024

And stop terrifying us with duplicated bugs ❗

Please start your contribution to the project! 🆗❔
What's your LinkedIn?

@SheruGaur
Copy link
Author

Thanks, you @raman-m for update and solution. Currently I am fully occupied in my ongoing project. Sure, I will be ready to contribute to your project whenever i am free up here.

@SheruGaur
Copy link
Author

@raman-m My linkdin id is Sheru Kumar Gaur

@raman-m
Copy link
Member

raman-m commented Mar 2, 2024

Please watch for PR #1592 #1590 news!
Closing because of duplication...

@raman-m raman-m closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identified as a potential bug Rate Limiting Ocelot feature: Rate Limiting
Projects
None yet
Development

No branches or pull requests

2 participants