Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: ' ' generates invalid CSS #249

Closed
rbilgil opened this issue May 2, 2017 · 4 comments
Closed

content: ' ' generates invalid CSS #249

rbilgil opened this issue May 2, 2017 · 4 comments

Comments

@rbilgil
Copy link

rbilgil commented May 2, 2017

When writing before and after pseudoelements, it's easy to mistakenly write content: '...' instead ofcontent: '"..."' in the content field. This generates invalid css in the stylesheet (resolving to content: px;). This should ideally raise an error instead of failing silently and doing the wrong thing.

@donaldpipowitch
Copy link
Collaborator

You're right. I did this mistake, too, when I started with glamor.

@miklschmidt
Copy link

Ditto, just made the same mistake.

@threepointone
Copy link
Owner

threepointone commented May 31, 2017 via email

@threepointone
Copy link
Owner

live in 2.20.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants