Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs3 feature detection is broken #130

Closed
lorenzhs opened this issue Oct 28, 2016 · 6 comments
Closed

libs3 feature detection is broken #130

lorenzhs opened this issue Oct 28, 2016 · 6 comments

Comments

@lorenzhs
Copy link
Member

Configuring fails if libcurl-dev (or another libs3 dependency) isn't installed or the submodule isn't there. It should fall back to not using S3 in this case.
@bingmann
Copy link
Member

Please submit a patch.

@lorenzhs
Copy link
Member Author

You broke it. You fix it!

@bingmann
Copy link
Member

Not broken. Install libcurl-dev / libcurl4-openssl-dev.

@lorenzhs
Copy link
Member Author

libs3 is not required though. This means that Thrill fails to build in its default configuration without these libraries. So it's broken.

@bingmann
Copy link
Member

Please submit a patch.

@lorenzhs
Copy link
Member Author

Are you a Markov chain? I don't know cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lorenzhs @bingmann