Potential issue with full synchronization 'since' timestamp

[JonOfUs]

On full synchronization, since timestamp is set to 0 and so only episode and subscription changes from within the last week will be synchronized.

Expected Behavior

Full synchronization after first synchronization

Current Behavior

Only episode actions and subscriptions from within last week will be synchronized

Possible Solution

If not intended, repair since-parameter or correct createDateTimeFromTimestamp to be able to deal with since=0

Steps to Reproduce

1. Install AntennaPod debug with current build 3edd01e (12-08-2021) & Install gpoddersync 1.0.9.
2. Do some subscription changes and create some episode actions
3. Wait >1 week
4. Delete app data, re-synchronize everything

Context (Environment)

Using MariaDB 10.3, php8.0, Nextcloud 22, gpoddersync 1.0.9, Raspberry Pi OS 64bit, nginx 1.14.2

Detailed Description

I recognized that after deleting AntennaPod app data and re-synchronizing subscriptions and episode changes, some episode changes won't synchronize.
After some digging I found out that the full synchronization feature calls /subscription_change/list with since=0 and therefore createDateTimeFromTimestamp will always return a timestamp from a week ago (because 0 is false).

The problem with this is that episode changes and subscriptions that are older than one week won't get synchronized.

Is this behaviour intended?

nextcloud-gpodder/lib/Controller/EpisodeActionController.php

Lines 95 to 104 in a87c010

	/**
	* @param int|null $since
	*
	* @return DateTime
	*/
	private function createDateTimeFromTimestamp(?int $since): DateTime {
	return ($since)
	? (new \DateTime)->setTimestamp($since)
	: (new \DateTime('-1 week'));
	}

If not intended, I could PR a fix, already found one.

[thrillfall]

Oh yes. The condition in line 101 should check for $since not being null.

A PR would very welcome

[thrillfall]

@JonOfUs you really don't need to go through the ordeal of filling any issue template if you clearly found the issue and can just shortly point out the bug in the code. Thanks for digging into this

[JonOfUs]

You're welcome!
Okay, I will try to hold me back next time ^^

[thrillfall]

@JonOfUs I'll take this commit as the opportunity to add automated releases with github actions. Your fix will then be the first to be released in that way. Please bear with me if it takes a few days

[JonOfUs]

Okay. I'll try to find some other things, a new version for just such a small patch always sounds a bit overkill.

[thrillfall]

Not at all. This is a bug. The fix must be released. Size doesn't matter.