Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on installing 3.0.0 from app store #39

Closed
mogwa1 opened this issue Oct 12, 2021 · 4 comments
Closed

Error on installing 3.0.0 from app store #39

mogwa1 opened this issue Oct 12, 2021 · 4 comments

Comments

@mogwa1
Copy link

mogwa1 commented Oct 12, 2021

See below for the error log. It seems to fail on TimestampMigration.php#45.
I don't know whether this might be the cause, but I'm running nextcloud 22 on PHP8.

I can GET and POST subscriptions just fine, but EpisodeAction POSTs don't seem to do anything. There's a timestamp response to the POST, but it looks like nothing is added to the database.

NB: Again, I don't know if it's related, but GET /index.php/apps/gpoddersync/episode_action fails without a since query. If I add any value for since then it works just fine.
Nevermind these remarks, I got it running.

{"reqId":"oer6QFcVkZBPWCmzZtHI","level":3,"time":"2021-10-12T18:47:27+00:00","remoteAddr":"xx.xx.xx.xx","user":"xxx","app":"PHP","method":"POST","url":"/index.php/settings/apps/enable","message":"Undefined variable $result at /var/lib/nextcloud/apps/gpoddersync/lib/Migration/TimestampMigration.php#45","userAgent":"xxx","version":"22.2.0.2","exception":{"Exception":"Error","Message":"Undefined variable $result at /var/lib/nextcloud/apps/gpoddersync/lib/Migration/TimestampMigration.php#45","Code":0,"Trace":[{"file":"/var/lib/nextcloud/apps/gpoddersync/lib/Migration/TimestampMigration.php","line":45,"function":"onError","class":"OC\\Log\\ErrorHandler","type":"::"},{"file":"/usr/share/webapps/nextcloud/lib/private/Repair.php","line":123,"function":"run","class":"OCA\\GPodderSync\\Migration\\TimestampMigration","type":"->"},{"file":"/usr/share/webapps/nextcloud/lib/private/legacy/OC_App.php","line":1059,"function":"run","class":"OC\\Repair","type":"->"},{"file":"/usr/share/webapps/nextcloud/lib/private/Installer.php","line":157,"function":"executeRepairSteps","class":"OC_App","type":"::"},{"file":"/usr/share/webapps/nextcloud/apps/settings/lib/Controller/AppSettingsController.php","line":447,"function":"installApp","class":"OC\\Installer","type":"->"},{"file":"/usr/share/webapps/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":217,"function":"enableApps","class":"OCA\\Settings\\Controller\\AppSettingsController","type":"->"},{"file":"/usr/share/webapps/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":126,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/usr/share/webapps/nextcloud/lib/private/AppFramework/App.php","line":156,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/usr/share/webapps/nextcloud/lib/private/Route/Router.php","line":301,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/usr/share/webapps/nextcloud/lib/base.php","line":1000,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/usr/share/webapps/nextcloud/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"/usr/share/webapps/nextcloud/lib/private/Log/ErrorHandler.php","Line":92,"CustomMessage":"--"},"id":"6165d85432919"}
@mogwa1
Copy link
Author

mogwa1 commented Oct 12, 2021

I've just tried rolling back to PHP7.4, but to no avail. The errors remain the same.
I might add that I've installed the app a while ago on one of the 1.x releases and have upgraded it multiple times.

@mogwa1
Copy link
Author

mogwa1 commented Oct 13, 2021

Looking at the code (I'm not a PHP expert), it looks like it's will throw the error when there are no items in the database to convert from datetime to unix timestamp. In that case $result will indeed not be defined.

If that's the case then the error itself is rather harmless since there was nothing to migrate.

@JonOfUs
Copy link
Collaborator

JonOfUs commented Oct 13, 2021

In that case $result will indeed not be defined.

Yes, this indeed is the problem. Fixed it in #40.

If that's the case then the error itself is rather harmless since there was nothing to migrate.

Yes, maintenance:repair didn't even mention this error on my setup - it just appeared in the log. Important to fix anyway.

@thrillfall
Copy link
Owner

Fixed. Thanks @JonOfUs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants