M.custom error drawable #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 25, 2014 14:08
…r(Context c, int errorMessageRes, Drawable errorDrawable) as well as an mErrorDrawable member variable in order to specify a custom error drawable. Added that constructor to concrete validators and updated Validate to handle the custom drawable
…ErrorNotification
|
@throrin19 sorry for creating the pull request against master. Hopefully these changes are helpful! |
|
@justincpollard I merge and release your contribution this week. Change the error drawable is verry useful. Thanks for that. If you have other improvements, do not hesistate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 things @justincpollard tried to do here: